Update Mono API calls to CoreCLR-compatible API calls #3780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR replaces all instances of
MonoAPI calls withCoreCLR-compatible API calls in this repo, and is part of Epic SCP-1555.Note:
More PRs dealing with SCP-1555 may come in the future. In some cases we cannot replace all
MonoAPI calls withCoreCLRAPI calls yet, as someCoreCLRAPIs are still being worked on/are not yet public (see for example SCP-1542, and SCP-1544). In these cases we suppress warnings for those particular APIs for now. Later on, once the equivalentCoreCLRAPIs are made public, we will do a second pass across all packages and replace the suppressed warning/old API with the new publicCoreCLRAPI instead.Further Context
Monoto usingCoreCLR.MonoAPI calls withCoreCLR-compatible ones. (here's the list of APIs being replaced, and here's the list of packages that will get updated).MonoAPI calls across all Unity supported packages withCoreCLR-compatible ones. This PR is part of that epic.Jira ticket
SCP-1557
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
Unsure if this PR should be backported. Please do advise and I will create PRs for backports too!
Comments to Reviewers
If there are any jobs/tests we should run to make sure there are no ripple effects do share and we will kick them off! :) And, if you know of any locations we may have missed updating or any details that we should know about, please do share!