Skip to content

fix: running the 'Fix Ignored Entries' tool from the menu bar causes an error in the log #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: running the 'Fix Ignored Entries' tool from the menu bar causes an error in the log #1188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
248c610
Pull `update_driver_widgets` out into the main class, and use that in…
TrigamDev Oct 31, 2025
eda721f
Merge branch 'TagStudioDev:main' into fix/remove-entries-missing-attr…
TrigamDev Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/tagstudio/qt/controllers/fix_ignored_modal_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def __init__(self, library: "Library", driver: "QtDriver"):
lambda: (
self.update_ignored_count(),
self.driver.update_browsing_state(),
self.driver.library_info_window.update_cleanup(),
self.update_driver_widgets(),
self.refresh_ignored(),
)
)
Expand All @@ -52,20 +52,13 @@ def refresh_ignored(self):
pw.setWindowTitle(Translations["library.scan_library.title"])
pw.update_label(Translations["entries.ignored.scanning"])

def update_driver_widgets():
if (
hasattr(self.driver, "library_info_window")
and self.driver.library_info_window.isVisible()
):
self.driver.library_info_window.update_cleanup()

pw.from_iterable_function(
self.tracker.refresh_ignored_entries,
None,
self.set_ignored_count,
self.update_ignored_count,
self.remove_modal.refresh_list,
update_driver_widgets,
self.update_driver_widgets,
)

def set_ignored_count(self):
Expand All @@ -88,6 +81,13 @@ def update_ignored_count(self):
)
self.ignored_count_label.setText(f"<h3>{count_text}</h3>")

def update_driver_widgets(self):
if (
hasattr(self.driver, "library_info_window")
and self.driver.library_info_window.isVisible()
):
self.driver.library_info_window.update_cleanup()

@override
def showEvent(self, event: QtGui.QShowEvent) -> None: # type: ignore
self.update_ignored_count()
Expand Down