-
Notifications
You must be signed in to change notification settings - Fork 105
microsoft-lts-jdk: Update to version 25.0.1 #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe Microsoft Build of OpenJDK manifest has been updated, upgrading from version 21.0.9 to 25.0.1. The distribution format switched from Windows x64 ZIP to MSI installer, arm64 support was removed, and installer scripts plus environment configuration sections were added. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. microsoft-lts-jdk
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
bucket/microsoft-lts-jdk.json (1)
25-25: Consider version pattern flexibility in checkver regex.The regex hardcodes
25[\\d.]*?, which prevents automatic detection of future versions (26+). If you anticipate future major version updates, consider making the major version more flexible, or note that manual regex updates will be required.Current pattern:
(?<ms>microsoft-jdk-((?<ver>25[\\d.]*?).(?<build>[\\d]+).[\\d]+)-windows-x64).msiFor future-proofing, consider:
(?<ms>microsoft-jdk-((?<ver>\\d+[\\d.]*?).(?<build>[\\d]+).[\\d]+)-windows-x64).msiHowever, verify that this aligns with Scoop's expectations and the actual file naming scheme at the source.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/microsoft-lts-jdk.json(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (4)
bucket/microsoft-lts-jdk.json (4)
6-11: Confirm that arm64 removal is intentional and documented.The manifest previously included an arm64 architecture block, which is now removed. This is a breaking change for users on ARM64 systems. Verify that:
- Microsoft no longer provides an ARM64 MSI distribution for version 25.0.1
- This removal is intentional and acceptable for this package
- Users on ARM64 systems are aware of this limitation or have fallback options
13-18: Verify installer script compatibility with Scoop execution context.The PowerShell installer script moves extracted files from
$dir\tmpto$dirand cleans up. This is a standard pattern for MSI extraction. Ensure:
- The script works correctly within Scoop's execution environment
- All paths and variable references are valid (e.g.,
$dir,$_)- Permissions allow recursive file operations and directory removal
36-36: Verify extract_dir variables match checkver named groups.Line 36 references
$matchVerand$matchBuild, which should be populated from the checkver regex named groups(?<ver>...)and(?<build>...)on line 25. Confirm that Scoop's update mechanism correctly captures and exposes these variables for this use case.
8-9: URL and hash verified as correct.The MSI URL resolves properly and the SHA256 hash
5ce322c00d8d56b99eeaec7abad6328f2b95f4d22e23558fc23b87464ff27597matches Microsoft's official published checksum for microsoft-jdk-25.0.1-windows-x64.msi.
Closes #XXXX
Relates to #XXXX
Summary by CodeRabbit
New Features
Chores