Skip to content

Conversation

@b4imetu
Copy link
Contributor

@b4imetu b4imetu commented Nov 2, 2025

Closes #XXXX

Relates to #XXXX

Summary by CodeRabbit

New Features

  • Windows 64-bit distribution now available as MSI installer format instead of ZIP file
  • JAVA_HOME environment variable and system PATH are automatically configured upon installation

Chores

  • Version updated to 25.0.1
  • Arm64 architecture support removed; 64-bit only
  • Download URLs and version detection patterns updated

@coderabbitai
Copy link

coderabbitai bot commented Nov 2, 2025

Walkthrough

The Microsoft Build of OpenJDK manifest has been updated, upgrading from version 21.0.9 to 25.0.1. The distribution format switched from Windows x64 ZIP to MSI installer, arm64 support was removed, and installer scripts plus environment configuration sections were added.

Changes

Cohort / File(s) Summary
Microsoft LTS JDK Manifest Update
bucket/microsoft-lts-jdk.json
Version upgraded 21.0.9 → 25.0.1; distribution format changed from ZIP to MSI for Windows x64; arm64 architecture block removed; checkver regex and autoupdate URLs updated to MSI pattern; installer script added for file extraction and cleanup; env_add_path (bin) and JAVA_HOME environment variable configured; description updated.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify SHA-256 hash accuracy for the new MSI file
  • Confirm checkver regex pattern correctly matches MSI URL format (version prefix changed from 21 to 25)
  • Validate installer script paths for temporary directory handling and cleanup
  • Test environment variable configuration (JAVA_HOME path and bin directory addition)

Suggested labels

review-needed

Suggested reviewers

  • se35710

Poem

🐰 Hop along with version twenty-five!
From zips to installers, Java's alive,
MSI magic makes paths align,
Environment variables shine so fine! ✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is largely incomplete and does not adequately follow the required template structure. While the contributing guide checkbox is properly marked as checked, the critical issue reference placeholder ("Closes #XXXX" or "Relates to #XXXX") has not been filled with an actual issue number and remains as a template placeholder. Additionally, no substantive summary of the changes has been provided in the description body beyond the template boilerplate. The template clearly requires either a "Closes" or "Relates to" reference linked to a real issue, which is essential for tracking and context. The PR description must be updated to include an actual issue reference. Replace "Closes #XXXX" or "Relates to #XXXX" with a valid issue number that addresses this version update or links to relevant discussion. Additionally, consider adding a brief summary of the key changes (version update, installer format change from ZIP to MSI, new environment configuration) to provide context for reviewers.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "microsoft-lts-jdk: Update to version 25.0.1" is clear, specific, and directly related to the main change in the changeset—the version bump from 21.0.9 to 25.0.1. The title follows the package name convention and concisely identifies the primary update. While the changeset also includes significant modifications such as switching from ZIP to MSI installer format and updating environment configurations, version updates are the primary identifier for package updates in manifest-based repositories. The title adequately summarizes the most important change from the developer's perspective without being vague or misleading.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

All changes look good.

Wait for review from human collaborators.

microsoft-lts-jdk

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
bucket/microsoft-lts-jdk.json (1)

25-25: Consider version pattern flexibility in checkver regex.

The regex hardcodes 25[\\d.]*?, which prevents automatic detection of future versions (26+). If you anticipate future major version updates, consider making the major version more flexible, or note that manual regex updates will be required.

Current pattern:

(?<ms>microsoft-jdk-((?<ver>25[\\d.]*?).(?<build>[\\d]+).[\\d]+)-windows-x64).msi

For future-proofing, consider:

(?<ms>microsoft-jdk-((?<ver>\\d+[\\d.]*?).(?<build>[\\d]+).[\\d]+)-windows-x64).msi

However, verify that this aligns with Scoop's expectations and the actual file naming scheme at the source.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 77e3b0c and 1fcea29.

📒 Files selected for processing (1)
  • bucket/microsoft-lts-jdk.json (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (4)
bucket/microsoft-lts-jdk.json (4)

6-11: Confirm that arm64 removal is intentional and documented.

The manifest previously included an arm64 architecture block, which is now removed. This is a breaking change for users on ARM64 systems. Verify that:

  1. Microsoft no longer provides an ARM64 MSI distribution for version 25.0.1
  2. This removal is intentional and acceptable for this package
  3. Users on ARM64 systems are aware of this limitation or have fallback options

13-18: Verify installer script compatibility with Scoop execution context.

The PowerShell installer script moves extracted files from $dir\tmp to $dir and cleans up. This is a standard pattern for MSI extraction. Ensure:

  1. The script works correctly within Scoop's execution environment
  2. All paths and variable references are valid (e.g., $dir, $_)
  3. Permissions allow recursive file operations and directory removal

36-36: Verify extract_dir variables match checkver named groups.

Line 36 references $matchVer and $matchBuild, which should be populated from the checkver regex named groups (?<ver>...) and (?<build>...) on line 25. Confirm that Scoop's update mechanism correctly captures and exposes these variables for this use case.


8-9: URL and hash verified as correct.

The MSI URL resolves properly and the SHA256 hash 5ce322c00d8d56b99eeaec7abad6328f2b95f4d22e23558fc23b87464ff27597 matches Microsoft's official published checksum for microsoft-jdk-25.0.1-windows-x64.msi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant