Skip to content

Conversation

@BiekerUdan
Copy link

The C generator was generating duplicate path parameter handling code when a parameter had format: uuid. This occurred because UUID parameters have both isString=true and isUuid=true flags set, causing both the {{#isString}} and {{#isUuid}} template blocks to execute.

The duplicate {{#isUuid}} block has been removed since it generated identical code to the {{#isString}} block. This makes UUID parameters consistent with email parameters, which already work this way (isEmail=true and isString=true, but only use the {{#isString}} block).

The generated code now compiles successfully without duplicate variable declarations.

Fixes #17448

@zhemant @ityuhui @michelealbano @eafer

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Nov 5, 2025

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@eafer
Copy link
Contributor

eafer commented Nov 5, 2025

Do you mind adding a test for your change to the petstore.yaml for C? So that it doesn't break again in the future.

@BiekerUdan BiekerUdan force-pushed the fix/c-uuid-path-param-duplication branch from 2634d3f to 9cb54aa Compare November 5, 2025 18:15
The C generator was generating duplicate path parameter handling code
when a parameter had format: uuid. This occurred because UUID parameters
have both isString=true and isUuid=true flags set, causing both the
{{#isString}} and {{#isUuid}} template blocks to execute.

The duplicate {{#isUuid}} block has been removed since it generated
identical code to the {{#isString}} block. This makes UUID parameters
consistent with email parameters, which already work this way
(isEmail=true and isString=true, but only use the {{#isString}} block).

The generated code now compiles successfully without duplicate variable
declarations.
@BiekerUdan BiekerUdan force-pushed the fix/c-uuid-path-param-duplication branch from 9cb54aa to b907eee Compare November 5, 2025 18:18
Adds endpoint with UUID path parameter to verify C generator produces compilable code without duplicate variable declarations.
@BiekerUdan
Copy link
Author

I fixed the attribution issue. And added '/pet/byUuid/{uuid}' to petstore.yaml and generated the samples.

This causes builds of the samples to fail before this PR is applied, and to pass after it is applied. I did not add any unit tests specifically for this, is that ok?

@eafer
Copy link
Contributor

eafer commented Nov 5, 2025

Yes, that's what I meant: just put something in place so that the sample build fails if we ever revert this by mistake. Thanks! Your changes look good to me, but I don't think all of the samples got refreshed for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [c] generated code contains duplicated segment resulting in compile error

3 participants