Skip to content

Conversation

@Bouillie
Copy link
Contributor

@Bouillie Bouillie commented Nov 4, 2025

  • Non-required field are now wrapped in an "Option" struct (as seen in the generichost generator)
  • Nullable fields use the nullable operator "?"
  • Fixes invalid model validation on required nullable fields (null values would fail even though they're valid)

The update concerns the restsharp, httpclient and unitywebrequest libraries.

Example of generated code:
public int RequiredNotnullableintegerProp { get; set; }
public int? RequiredNullableIntegerProp { get; set; }
public Option<int?> NotRequiredNullableIntegerProp { get; set; }
public Option<int> NotRequiredNotnullableintegerProp { get; set; }

Those are breaking changes because of the type change of fields and function parameters from T? to Option<T>

Notes : I made sure not to impact the generichost library as it already handles Options. I also took null reference types into account.

Fixes: #22254 #21090

@mandrean @shibayan @Blackclaws @lucamazzanti @iBicha

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Olivier Leonard added 30 commits October 30, 2025 14:19
- Not required fields are wrapped in an Option struct
- Nullable field use "?" when appropriate
- Breaking changes, as non required fields previously used "?"

# Conflicts:
#	modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/CSharpClientCodegen.java
#	modules/openapi-generator/src/main/resources/csharp/modelGeneric.mustache
# Conflicts:
#	modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/CSharpClientCodegen.java
# Conflicts:
#	modules/openapi-generator/src/main/resources/csharp/api.mustache
#	modules/openapi-generator/src/main/resources/csharp/libraries/httpclient/api.mustache
#	modules/openapi-generator/src/main/resources/csharp/libraries/unityWebRequest/api.mustache
#	modules/openapi-generator/src/test/java/org/openapitools/codegen/csharpnetcore/CSharpOperationTest.java
# Conflicts:
#	modules/openapi-generator/src/main/resources/csharp/libraries/httpclient/api.mustache
# Conflicts:
#	modules/openapi-generator/src/main/resources/csharp/api.mustache
#	modules/openapi-generator/src/main/resources/csharp/libraries/unityWebRequest/api.mustache
# Conflicts:
#	modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenConstants.java
#	modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractCSharpCodegen.java
#	modules/openapi-generator/src/main/resources/csharp/api.mustache
#	modules/openapi-generator/src/main/resources/csharp/libraries/httpclient/api.mustache
#	modules/openapi-generator/src/main/resources/csharp/libraries/unityWebRequest/api.mustache
# Conflicts:
#	modules/openapi-generator/src/test/java/org/openapitools/codegen/csharpnetcore/CSharpModelTest.java
# Conflicts:
#	samples/client/petstore/csharp/restsharp/net7/EnumMappings/src/Org.OpenAPITools/Client/ApiClient.cs
@Bouillie
Copy link
Contributor Author

Bouillie commented Nov 4, 2025

I've checked the failing tests.

  • 4 tests are failing due to github changes that are not related to my changes.
  • 1 test fails because I made changes to PetApiTests to reflect the breaking changes of my update, they're supposed to be made. What should I do ?

Olivier Leonard added 5 commits November 4, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant