Allow folks to close the full-screen Preferences modal by pressing the Escape key #6026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! When I was playing with Hubs' great new demo room recently, I went into Preferences to boost the room's media volume. I noticed that I couldn't close the full-screen Preferences window with an Escape keypress, though I felt like I should be able to (both from a "UX patterns" perspective and because other elements within the UI are closeable with Esc).
This PR lets people close the Preferences window with Escape and get right back to the action without leaving their keyboard.
Also, I noticed that when I ran
npm run testas per the Contributing guidelines, I got this error:I'm not sure if this is worth opening a new issue.