anycubic-slicer-next 1.3.7.3 (new cask)

[yutaIMD]

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

• The submission is for a stable version or documented exception.
• brew audit --cask --online <cask> is error-free.
• brew style --fix <cask> reports no offenses.

Additionally, if adding a new cask:

• Named the cask according to the token reference.
• Checked the cask was not already refused (add your cask's name to the end of the search field).
• brew audit --cask --new <cask> worked successfully.
• HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
• brew uninstall --cask <cask> worked successfully.

---

[bevanjkay]

Suggested change

	strategy :page_match do |page|
	page.scan(/V(\d+(?:\.\d+)+)/i).flatten.first
	end
	regex(V(\d+(?:\.\d+)+)/i)

We will need a regex that is more closely anchored to a url or something, not just any number after "V". But you also don't need to do block here.

[bevanjkay]

There are a lot of variable parts in this url that will change between versions, these will need to be captured somehow and stored in the version, so that the cask can be updated systematically.

[samford]

I shouldn't have to point this out but this does not include the URL parts in the returned version string.

This regex is used to match the version parts, so it should be set using a regex() call and passed into the strategy block (not inline in the strategy block).

This is also capturing the full href attributes for the arch-specific files instead of capturing only the distinct parts from each URL that will vary. To say the least, this isn't doing what was asked in #234863 (comment). There are many examples in existing casks that you can refer to for inspiration (e.g., sq-mixpad).

Besides that, we use match[1] instead of match.captures[0] (for the sake of brevity), so this doesn't adhere to typical strategy block code patterns. Again, there are thousands of existing strategy blocks for you to refer to (some are better than others but typical patterns start to become clear after looking through a few).