This repository was archived by the owner on Aug 22, 2023. It is now read-only.
Remove Query\Builder::__constructor overload
#26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
query-builder-constructor
branch
from
dc0ef90 to
9ba9607
Compare
GromNaN
commented
Aug 21, 2023
| * @inheritdoc | ||
| */ | ||
| public function raw($expression = null) | ||
| public function raw($value = null) |
Owner
Author
There was a problem hiding this comment.
Get the argument name from the parent method.
GromNaN
force-pushed
the
query-builder-constructor
branch
from
9ba9607 to
027166e
Compare
jmikola
approved these changes
Aug 21, 2023
Collaborator
jmikola
left a comment
jmikola
left a comment
There was a problem hiding this comment.
LGTM assuming no behavioral changes (see question).
| * @inheritdoc | ||
| */ | ||
| public function raw($expression = null) | ||
| public function raw($value = null) |
Collaborator
There was a problem hiding this comment.
I assume this is related to https://github.com/GromNaN/laravel-mongodb/pull/26/files#r1300010923.
| public function newQuery() | ||
| { | ||
| return new self($this->connection, $this->processor); | ||
| return new self($this->connection, null, $this->processor); |
Collaborator
There was a problem hiding this comment.
Is a null second argument equivalent to constructing a new Grammar object (perhaps by way of calling Connection::getQueryGrammar()), as was done in the original overridden constructor (before the changes in this PR)?
Just want to confirm there's no behavioral change here.
Owner
Author
|
Moved to mongodb/laravel-mongodb#2570 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor don't need to be overloaded to set the default grammar. It is read from the connection by default.
https://github.com/laravel/framework/blob/10.x/src/Illuminate/Database/Query/Builder.php#L246