add a feature flag to disable extra calls to the DB in JDBC instrumentation #9774

vandonr · 2025-10-16T09:52:51Z

What Does This Do

the JDBC instrumentation does extra calls to the DB to fetch the metadata and client info. In case this might cause issues, we want to be able to disable this behavior to reduce the instrumentation to simply creating spans.

Motivation

customer investigation

Additional Notes

missing tests for now

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMS-16143

datadog-official · 2025-10-16T10:10:06Z

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 59.68% (-0.03%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: a4ec186 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

pr-commenter · 2025-10-16T10:24:53Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/jdbc-ff
git_commit_date	1762179170	1762255059
git_commit_sha	`364bb8b`	`a4ec186`
release_version	1.55.0-SNAPSHOT~364bb8b68f	1.55.0-SNAPSHOT~a4ec186c19

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1762257240	1762257240
ci_job_id	1214265754	1214265754
ci_pipeline_id	81175363	81175363
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-runmvlj6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-runmvlj6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 50 metrics, 14 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:petclinic:appsec:Debugger	worse [+143.365µs; +308.963µs] or [+2.450%; +5.281%]	6.077ms	5.851ms

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~a4ec186c19, baseline=1.55.0-SNAPSHOT~364bb8b68f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.028 s) : 0, 1027741
Total [baseline] (8.716 s) : 0, 8715994
Agent [candidate] (1.02 s) : 0, 1020213
Total [candidate] (8.67 s) : 0, 8670007
section iast
Agent [baseline] (1.17 s) : 0, 1170020
Total [baseline] (9.369 s) : 0, 9368754
Agent [candidate] (1.154 s) : 0, 1153631
Total [candidate] (9.349 s) : 0, 9349234

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.028 s	-
Agent	iast	1.17 s	142.279 ms (13.8%)
Total	tracing	8.716 s	-
Total	iast	9.369 s	652.76 ms (7.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.02 s	-
Agent	iast	1.154 s	133.417 ms (13.1%)
Total	tracing	8.67 s	-
Total	iast	9.349 s	679.226 ms (7.8%)

gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~a4ec186c19, baseline=1.55.0-SNAPSHOT~364bb8b68f

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.49 ms) : 0, 1490
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (700.71 ms) : 0, 700710
BytebuddyAgent [candidate] (694.581 ms) : 0, 694581
GlobalTracer [baseline] (244.608 ms) : 0, 244608
GlobalTracer [candidate] (243.081 ms) : 0, 243081
AppSec [baseline] (32.327 ms) : 0, 32327
AppSec [candidate] (32.087 ms) : 0, 32087
Debugger [baseline] (6.368 ms) : 0, 6368
Debugger [candidate] (6.251 ms) : 0, 6251
Remote Config [baseline] (692.506 µs) : 0, 693
Remote Config [candidate] (668.513 µs) : 0, 669
Telemetry [baseline] (13.86 ms) : 0, 13860
Telemetry [candidate] (9.2 ms) : 0, 9200
Flare Poller [baseline] (6.514 ms) : 0, 6514
Flare Poller [candidate] (11.659 ms) : 0, 11659
section iast
crashtracking [baseline] (1.498 ms) : 0, 1498
crashtracking [candidate] (1.489 ms) : 0, 1489
BytebuddyAgent [baseline] (832.906 ms) : 0, 832906
BytebuddyAgent [candidate] (816.764 ms) : 0, 816764
GlobalTracer [baseline] (233.674 ms) : 0, 233674
GlobalTracer [candidate] (232.293 ms) : 0, 232293
IAST [baseline] (32.482 ms) : 0, 32482
IAST [candidate] (26.726 ms) : 0, 26726
AppSec [baseline] (28.673 ms) : 0, 28673
AppSec [candidate] (35.178 ms) : 0, 35178
Debugger [baseline] (6.118 ms) : 0, 6118
Debugger [candidate] (6.163 ms) : 0, 6163
Remote Config [baseline] (590.317 µs) : 0, 590
Remote Config [candidate] (674.937 µs) : 0, 675
Telemetry [baseline] (8.397 ms) : 0, 8397
Telemetry [candidate] (8.695 ms) : 0, 8695
Flare Poller [baseline] (4.164 ms) : 0, 4164
Flare Poller [candidate] (4.214 ms) : 0, 4214

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~a4ec186c19, baseline=1.55.0-SNAPSHOT~364bb8b68f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1029108
Total [baseline] (10.778 s) : 0, 10777805
Agent [candidate] (1.024 s) : 0, 1023606
Total [candidate] (10.686 s) : 0, 10685771
section appsec
Agent [baseline] (1.201 s) : 0, 1200779
Total [baseline] (10.963 s) : 0, 10962704
Agent [candidate] (1.197 s) : 0, 1197437
Total [candidate] (10.813 s) : 0, 10813212
section iast
Agent [baseline] (1.164 s) : 0, 1163640
Total [baseline] (11.104 s) : 0, 11103796
Agent [candidate] (1.159 s) : 0, 1159361
Total [candidate] (11.138 s) : 0, 11137742
section profiling
Agent [baseline] (1.172 s) : 0, 1171974
Total [baseline] (10.968 s) : 0, 10968264
Agent [candidate] (1.165 s) : 0, 1164900
Total [candidate] (10.808 s) : 0, 10807721

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.029 s	-
Agent	appsec	1.201 s	171.671 ms (16.7%)
Agent	iast	1.164 s	134.532 ms (13.1%)
Agent	profiling	1.172 s	142.866 ms (13.9%)
Total	tracing	10.778 s	-
Total	appsec	10.963 s	184.899 ms (1.7%)
Total	iast	11.104 s	325.991 ms (3.0%)
Total	profiling	10.968 s	190.459 ms (1.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.024 s	-
Agent	appsec	1.197 s	173.831 ms (17.0%)
Agent	iast	1.159 s	135.755 ms (13.3%)
Agent	profiling	1.165 s	141.294 ms (13.8%)
Total	tracing	10.686 s	-
Total	appsec	10.813 s	127.441 ms (1.2%)
Total	iast	11.138 s	451.971 ms (4.2%)
Total	profiling	10.808 s	121.95 ms (1.1%)

gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~a4ec186c19, baseline=1.55.0-SNAPSHOT~364bb8b68f

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (701.552 ms) : 0, 701552
BytebuddyAgent [candidate] (697.901 ms) : 0, 697901
GlobalTracer [baseline] (244.813 ms) : 0, 244813
GlobalTracer [candidate] (244.546 ms) : 0, 244546
AppSec [baseline] (32.201 ms) : 0, 32201
AppSec [candidate] (32.575 ms) : 0, 32575
Debugger [baseline] (6.37 ms) : 0, 6370
Debugger [candidate] (6.377 ms) : 0, 6377
Remote Config [baseline] (683.439 µs) : 0, 683
Remote Config [candidate] (684.273 µs) : 0, 684
Telemetry [baseline] (15.799 ms) : 0, 15799
Telemetry [candidate] (9.44 ms) : 0, 9440
Flare Poller [baseline] (4.987 ms) : 0, 4987
Flare Poller [candidate] (9.408 ms) : 0, 9408
section appsec
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (724.766 ms) : 0, 724766
BytebuddyAgent [candidate] (720.259 ms) : 0, 720259
GlobalTracer [baseline] (235.868 ms) : 0, 235868
GlobalTracer [candidate] (235.344 ms) : 0, 235344
IAST [baseline] (24.862 ms) : 0, 24862
IAST [candidate] (24.896 ms) : 0, 24896
AppSec [baseline] (174.049 ms) : 0, 174049
AppSec [candidate] (175.209 ms) : 0, 175209
Debugger [baseline] (5.851 ms) : 0, 5851
Debugger [candidate] (6.077 ms) : 0, 6077
Remote Config [baseline] (626.339 µs) : 0, 626
Remote Config [candidate] (654.879 µs) : 0, 655
Telemetry [baseline] (8.33 ms) : 0, 8330
Telemetry [candidate] (8.469 ms) : 0, 8469
Flare Poller [baseline] (3.861 ms) : 0, 3861
Flare Poller [candidate] (3.872 ms) : 0, 3872
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.481 ms) : 0, 1481
BytebuddyAgent [baseline] (825.751 ms) : 0, 825751
BytebuddyAgent [candidate] (821.222 ms) : 0, 821222
GlobalTracer [baseline] (234.32 ms) : 0, 234320
GlobalTracer [candidate] (233.269 ms) : 0, 233269
IAST [baseline] (32.463 ms) : 0, 32463
IAST [candidate] (26.843 ms) : 0, 26843
AppSec [baseline] (28.846 ms) : 0, 28846
AppSec [candidate] (35.251 ms) : 0, 35251
Debugger [baseline] (6.175 ms) : 0, 6175
Debugger [candidate] (6.182 ms) : 0, 6182
Remote Config [baseline] (598.769 µs) : 0, 599
Remote Config [candidate] (599.886 µs) : 0, 600
Telemetry [baseline] (8.473 ms) : 0, 8473
Telemetry [candidate] (8.707 ms) : 0, 8707
Flare Poller [baseline] (4.177 ms) : 0, 4177
Flare Poller [candidate] (4.24 ms) : 0, 4240
section profiling
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (724.023 ms) : 0, 724023
BytebuddyAgent [candidate] (721.593 ms) : 0, 721593
GlobalTracer [baseline] (220.918 ms) : 0, 220918
GlobalTracer [candidate] (219.375 ms) : 0, 219375
AppSec [baseline] (33.212 ms) : 0, 33212
AppSec [candidate] (32.236 ms) : 0, 32236
Debugger [baseline] (9.861 ms) : 0, 9861
Debugger [candidate] (6.676 ms) : 0, 6676
Remote Config [baseline] (717.864 µs) : 0, 718
Remote Config [candidate] (692.748 µs) : 0, 693
Telemetry [baseline] (12.165 ms) : 0, 12165
Telemetry [candidate] (15.707 ms) : 0, 15707
Flare Poller [baseline] (4.134 ms) : 0, 4134
Flare Poller [candidate] (4.204 ms) : 0, 4204
ProfilingAgent [baseline] (110.131 ms) : 0, 110131
ProfilingAgent [candidate] (109.077 ms) : 0, 109077
Profiling [baseline] (110.744 ms) : 0, 110744
Profiling [candidate] (109.702 ms) : 0, 109702

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/jdbc-ff
git_commit_date	1762179170	1762255059
git_commit_sha	`364bb8b`	`a4ec186`
release_version	1.55.0-SNAPSHOT~364bb8b68f	1.55.0-SNAPSHOT~a4ec186c19

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1762256924	1762256924
ci_job_id	1214265755	1214265755
ci_pipeline_id	81175363	81175363
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-2o2reonf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-2o2reonf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 4 performance improvements and 2 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:profiling:high_load	worse [+212.839µs; +519.553µs] or [+2.450%; +5.982%]	unstable [-84.475op/s; +41.350op/s] or [-15.817%; +7.742%]	9.052ms	512.531op/s	8.686ms	534.094op/s
scenario:load:insecure-bank:iast:high_load	better [-684.321µs; -327.130µs] or [-6.684%; -3.195%]	unstable [-29.551op/s; +76.051op/s] or [-6.513%; +16.760%]	9.733ms	477.000op/s	10.238ms	453.750op/s
scenario:load:insecure-bank:tracing:high_load	better [-536.496µs; -295.567µs] or [-6.717%; -3.700%]	unstable [-41.082op/s; +104.269op/s] or [-7.084%; +17.979%]	7.572ms	611.531op/s	7.988ms	579.938op/s
scenario:load:petclinic:no_agent:high_load	better [-2.596ms; -1.954ms] or [-6.786%; -5.109%]	unstable [-1.366op/s; +16.716op/s] or [-1.118%; +13.673%]	35.976ms	129.938op/s	38.251ms	122.263op/s
scenario:load:petclinic:tracing:high_load	better [-2.550ms; -1.733ms] or [-5.801%; -3.943%]	unstable [-2.742op/s; +13.542op/s] or [-2.577%; +12.725%]	41.818ms	111.825op/s	43.960ms	106.425op/s
scenario:load:petclinic:profiling:high_load	worse [+1.435ms; +2.448ms] or [+3.010%; +5.136%]	unstable [-11.442op/s; +3.717op/s] or [-11.657%; +3.787%]	49.618ms	94.300op/s	47.676ms	98.162op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~a4ec186c19, baseline=1.55.0-SNAPSHOT~364bb8b68f
    dateFormat X
    axisFormat %s
section baseline
no_agent (38.251 ms) : 37943, 38560
.   : milestone, 38251,
appsec (47.984 ms) : 47568, 48400
.   : milestone, 47984,
code_origins (44.342 ms) : 43951, 44733
.   : milestone, 44342,
iast (44.228 ms) : 43849, 44606
.   : milestone, 44228,
profiling (47.676 ms) : 47216, 48136
.   : milestone, 47676,
tracing (43.96 ms) : 43574, 44345
.   : milestone, 43960,
section candidate
no_agent (35.976 ms) : 35689, 36264
.   : milestone, 35976,
appsec (46.899 ms) : 46496, 47303
.   : milestone, 46899,
code_origins (44.161 ms) : 43774, 44548
.   : milestone, 44161,
iast (43.97 ms) : 43586, 44354
.   : milestone, 43970,
profiling (49.618 ms) : 49136, 50099
.   : milestone, 49618,
tracing (41.818 ms) : 41445, 42191
.   : milestone, 41818,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	38.251 ms [37.943 ms, 38.56 ms]	-
appsec	47.984 ms [47.568 ms, 48.4 ms]	9.732 ms (25.4%)
code_origins	44.342 ms [43.951 ms, 44.733 ms]	6.09 ms (15.9%)
iast	44.228 ms [43.849 ms, 44.606 ms]	5.976 ms (15.6%)
profiling	47.676 ms [47.216 ms, 48.136 ms]	9.424 ms (24.6%)
tracing	43.96 ms [43.574 ms, 44.345 ms]	5.708 ms (14.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	35.976 ms [35.689 ms, 36.264 ms]	-
appsec	46.899 ms [46.496 ms, 47.303 ms]	10.923 ms (30.4%)
code_origins	44.161 ms [43.774 ms, 44.548 ms]	8.184 ms (22.7%)
iast	43.97 ms [43.586 ms, 44.354 ms]	7.994 ms (22.2%)
profiling	49.618 ms [49.136 ms, 50.099 ms]	13.641 ms (37.9%)
tracing	41.818 ms [41.445 ms, 42.191 ms]	5.842 ms (16.2%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~a4ec186c19, baseline=1.55.0-SNAPSHOT~364bb8b68f
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.376 ms) : 4326, 4426
.   : milestone, 4376,
iast (10.238 ms) : 10067, 10410
.   : milestone, 10238,
iast_FULL (13.794 ms) : 13526, 14063
.   : milestone, 13794,
iast_GLOBAL (11.119 ms) : 10919, 11320
.   : milestone, 11119,
profiling (8.686 ms) : 8541, 8831
.   : milestone, 8686,
tracing (7.988 ms) : 7871, 8104
.   : milestone, 7988,
section candidate
no_agent (4.406 ms) : 4348, 4464
.   : milestone, 4406,
iast (9.733 ms) : 9573, 9893
.   : milestone, 9733,
iast_FULL (13.859 ms) : 13588, 14130
.   : milestone, 13859,
iast_GLOBAL (10.823 ms) : 10633, 11013
.   : milestone, 10823,
profiling (9.052 ms) : 8912, 9192
.   : milestone, 9052,
tracing (7.572 ms) : 7464, 7679
.   : milestone, 7572,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.376 ms [4.326 ms, 4.426 ms]	-
iast	10.238 ms [10.067 ms, 10.41 ms]	5.862 ms (133.9%)
iast_FULL	13.794 ms [13.526 ms, 14.063 ms]	9.418 ms (215.2%)
iast_GLOBAL	11.119 ms [10.919 ms, 11.32 ms]	6.743 ms (154.1%)
profiling	8.686 ms [8.541 ms, 8.831 ms]	4.31 ms (98.5%)
tracing	7.988 ms [7.871 ms, 8.104 ms]	3.611 ms (82.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.406 ms [4.348 ms, 4.464 ms]	-
iast	9.733 ms [9.573 ms, 9.893 ms]	5.326 ms (120.9%)
iast_FULL	13.859 ms [13.588 ms, 14.13 ms]	9.452 ms (214.5%)
iast_GLOBAL	10.823 ms [10.633 ms, 11.013 ms]	6.417 ms (145.6%)
profiling	9.052 ms [8.912 ms, 9.192 ms]	4.646 ms (105.4%)
tracing	7.572 ms [7.464 ms, 7.679 ms]	3.165 ms (71.8%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/jdbc-ff
git_commit_date	1762179170	1762255059
git_commit_sha	`364bb8b`	`a4ec186`
release_version	1.55.0-SNAPSHOT~364bb8b68f	1.55.0-SNAPSHOT~a4ec186c19

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1762257461	1762257461
ci_job_id	1214265756	1214265756
ci_pipeline_id	81175363	81175363
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-9n8e2xqd 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-9n8e2xqd 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~a4ec186c19, baseline=1.55.0-SNAPSHOT~364bb8b68f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
.   : milestone, 1478,
appsec (3.681 ms) : 3469, 3894
.   : milestone, 3681,
iast (2.222 ms) : 2159, 2286
.   : milestone, 2222,
iast_GLOBAL (2.258 ms) : 2194, 2322
.   : milestone, 2258,
profiling (2.066 ms) : 2014, 2117
.   : milestone, 2066,
tracing (2.038 ms) : 1988, 2088
.   : milestone, 2038,
section candidate
no_agent (1.486 ms) : 1474, 1498
.   : milestone, 1486,
appsec (3.647 ms) : 3433, 3861
.   : milestone, 3647,
iast (2.205 ms) : 2141, 2269
.   : milestone, 2205,
iast_GLOBAL (2.264 ms) : 2199, 2328
.   : milestone, 2264,
profiling (2.05 ms) : 1999, 2101
.   : milestone, 2050,
tracing (2.026 ms) : 1976, 2075
.   : milestone, 2026,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.467 ms, 1.49 ms]	-
appsec	3.681 ms [3.469 ms, 3.894 ms]	2.203 ms (149.0%)
iast	2.222 ms [2.159 ms, 2.286 ms]	744.008 µs (50.3%)
iast_GLOBAL	2.258 ms [2.194 ms, 2.322 ms]	779.486 µs (52.7%)
profiling	2.066 ms [2.014 ms, 2.117 ms]	587.316 µs (39.7%)
tracing	2.038 ms [1.988 ms, 2.088 ms]	559.51 µs (37.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.486 ms [1.474 ms, 1.498 ms]	-
appsec	3.647 ms [3.433 ms, 3.861 ms]	2.161 ms (145.4%)
iast	2.205 ms [2.141 ms, 2.269 ms]	719.055 µs (48.4%)
iast_GLOBAL	2.264 ms [2.199 ms, 2.328 ms]	777.745 µs (52.3%)
profiling	2.05 ms [1.999 ms, 2.101 ms]	563.942 µs (38.0%)
tracing	2.026 ms [1.976 ms, 2.075 ms]	539.629 µs (36.3%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~a4ec186c19, baseline=1.55.0-SNAPSHOT~364bb8b68f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.594 s) : 15594000, 15594000
.   : milestone, 15594000,
appsec (14.824 s) : 14824000, 14824000
.   : milestone, 14824000,
iast (18.679 s) : 18679000, 18679000
.   : milestone, 18679000,
iast_GLOBAL (18.049 s) : 18049000, 18049000
.   : milestone, 18049000,
profiling (15.385 s) : 15385000, 15385000
.   : milestone, 15385000,
tracing (15.117 s) : 15117000, 15117000
.   : milestone, 15117000,
section candidate
no_agent (14.908 s) : 14908000, 14908000
.   : milestone, 14908000,
appsec (14.7 s) : 14700000, 14700000
.   : milestone, 14700000,
iast (18.522 s) : 18522000, 18522000
.   : milestone, 18522000,
iast_GLOBAL (18.086 s) : 18086000, 18086000
.   : milestone, 18086000,
profiling (14.947 s) : 14947000, 14947000
.   : milestone, 14947000,
tracing (15.086 s) : 15086000, 15086000
.   : milestone, 15086000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.594 s [15.594 s, 15.594 s]	-
appsec	14.824 s [14.824 s, 14.824 s]	-770.0 ms (-4.9%)
iast	18.679 s [18.679 s, 18.679 s]	3.085 s (19.8%)
iast_GLOBAL	18.049 s [18.049 s, 18.049 s]	2.455 s (15.7%)
profiling	15.385 s [15.385 s, 15.385 s]	-209.0 ms (-1.3%)
tracing	15.117 s [15.117 s, 15.117 s]	-477.0 ms (-3.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.908 s [14.908 s, 14.908 s]	-
appsec	14.7 s [14.7 s, 14.7 s]	-208.0 ms (-1.4%)
iast	18.522 s [18.522 s, 18.522 s]	3.614 s (24.2%)
iast_GLOBAL	18.086 s [18.086 s, 18.086 s]	3.178 s (21.3%)
profiling	14.947 s [14.947 s, 14.947 s]	39.0 ms (0.3%)
tracing	15.086 s [15.086 s, 15.086 s]	178.0 ms (1.2%)

internal-api/src/test/groovy/datadog/trace/api/ConfigTest.groovy

AlexeyKuznetsov-DD · 2025-10-16T13:11:56Z

...ent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/JDBCDecorator.java

+          try {
+            clientInfo = connection.getClientInfo();
+          } catch (final Throwable ex) {
+            // getClientInfo is likely not allowed, we can still extract info from the url alone


Maybe make sense to put some debug/trace log? Just thinking out loud.

you mean for investigation in the current case, or in general ?

I think it could help for investigation in the current case! I have no scale for how often this method is called though -- would adding debug statements here be "okay" in a production environment where we don't want to spam logs?

added a log, we'll need to make sure this is not merged to main if we want to keep the feature flags for further investigations

Cool thanks! I'll add a do not merge tag for now to remind us

AlexeyKuznetsov-DD

LGTM

vandonr added 2 commits October 16, 2025 10:57

add config flags but in the wrong place

e29146f

move flags

a685b20

vandonr added type: feature request inst: jdbc JDBC instrumentation labels Oct 16, 2025

AlexeyKuznetsov-DD reviewed Oct 16, 2025

View reviewed changes

internal-api/src/test/groovy/datadog/trace/api/ConfigTest.groovy Outdated Show resolved Hide resolved

AlexeyKuznetsov-DD reviewed Oct 16, 2025

View reviewed changes

AlexeyKuznetsov-DD approved these changes Oct 16, 2025

View reviewed changes

vandonr added 4 commits October 16, 2025 17:02

read config only once

1b7f677

remove spotless:off comment

cd6e512

add test

ea2c982

add debug logs in error cases

4a1d0cb

sarahchen6 added the tag: do not merge Do not merge changes label Oct 20, 2025

vandonr added 2 commits October 21, 2025 13:04

Merge remote-tracking branch 'origin/master' into vandonr/jdbc-ff

9ac990b

add flag to disable metadata fetching in driver

a4ec186

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add a feature flag to disable extra calls to the DB in JDBC instrumentation #9774

add a feature flag to disable extra calls to the DB in JDBC instrumentation #9774

Uh oh!

vandonr commented Oct 16, 2025 •

edited by atlassian bot

Loading

Uh oh!

datadog-official bot commented Oct 16, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

Uh oh!

pr-commenter bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

AlexeyKuznetsov-DD Oct 16, 2025

Uh oh!

vandonr Oct 16, 2025

Uh oh!

sarahchen6 Oct 17, 2025

Uh oh!

vandonr Oct 20, 2025

Uh oh!

sarahchen6 Oct 20, 2025

Uh oh!

AlexeyKuznetsov-DD left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

add a feature flag to disable extra calls to the DB in JDBC instrumentation #9774

Are you sure you want to change the base?

add a feature flag to disable extra calls to the DB in JDBC instrumentation #9774

Uh oh!

Conversation

vandonr commented Oct 16, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-official bot commented Oct 16, 2025 • edited by datadog-datadog-prod-us1 bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

AlexeyKuznetsov-DD Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

vandonr Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

sarahchen6 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

vandonr Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

sarahchen6 Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vandonr commented Oct 16, 2025 •

edited by atlassian bot

Loading

datadog-official bot commented Oct 16, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

pr-commenter bot commented Oct 16, 2025 •

edited

Loading