Fixing @param for loadFixtures()
#41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the FQCN is necessary for the generated TesterAction.php files.
W0rma
suggested changes
Nov 13, 2025
Contributor
W0rma
left a comment
W0rma
left a comment
There was a problem hiding this comment.
@ThomasLandauer Are you sure that the FQCN is necessary?
| * This method requires [`doctrine/data-fixtures`](https://github.com/doctrine/data-fixtures) to be installed. | ||
| * | ||
| * @param class-string<FixtureInterface>|class-string<FixtureInterface>[]|list<FixtureInterface> $fixtures | ||
| * @param class-string<\Doctrine\Common\DataFixtures\FixtureInterface>|class-string<\Doctrine\Common\DataFixtures\FixtureInterface>[]|list<\Doctrine\Common\DataFixtures\FixtureInterface> $fixtures |
Contributor
There was a problem hiding this comment.
@ThomasLandauer Are you sure that the FQCN is necessary?
IMO the existing use statement should be sufficient.
Member
Author
There was a problem hiding this comment.
That use isn't copied over into the generated FunctionalTesterActions.php. And since that file doesn't have any uses at all, I figured the easiest way is to add the FQCN here. It's indeed ugly, but usually nobody looks into those Action files anyway...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the FQCN is necessary for the generated TesterAction.php files.