Skip to content

NativeEngine: Support Blob in createImageBitmap #17411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 7, 2025
+15 −14
Merged

NativeEngine: Support Blob in createImageBitmap #17411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3054095
Align type with native implementation
alexchuber Nov 7, 2025
9a280ac
Remove wrapping promise; the async keyword should suffice
alexchuber Nov 7, 2025
f3e1a16
Handle Blob
alexchuber Nov 7, 2025
0c35a39
Update packages/dev/core/src/Engines/nativeEngine.ts
alexchuber Nov 7, 2025
1ccd1ba
Whitespace
alexchuber Nov 7, 2025
dfed35f
Add TODO for Blob hack
alexchuber Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/dev/core/src/Engines/Native/nativeInterfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export interface INativeEngine {
bufferLength: number
): Promise<ArrayBuffer>;

createImageBitmap(data: ArrayBufferView | IImage): ImageBitmap;
createImageBitmap(data: ArrayBuffer | IImage): ImageBitmap;
resizeImageBitmap(image: ImageBitmap, bufferWidth: number, bufferHeight: number): Uint8Array;

createFrameBuffer(
Expand Down
27 changes: 14 additions & 13 deletions packages/dev/core/src/Engines/nativeEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,7 @@ export class NativeEngine extends Engine {
};
}

// TODO: Remove in next protocol version update
if (typeof Blob === "undefined") {
(window.Blob as any) = function (v: any) {
return v;
Expand Down Expand Up @@ -2063,20 +2064,20 @@ export class NativeEngine extends Engine {
* @returns ImageBitmap
*/
public override async createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap> {
return await new Promise((resolve, reject) => {
if (Array.isArray(image)) {
const arr = <Array<ArrayBufferView>>image;
if (arr.length) {
const image = this._engine.createImageBitmap(arr[0]);
if (image) {
resolve(image);
return;
}
}
// Back-compat: Because of the previous Blob hack, this could be an array of BlobParts.
if (Array.isArray(image)) {
const arr = <Array<ArrayBuffer>>image;
if (arr.length) {
return this._engine.createImageBitmap(arr[0]);
}
// eslint-disable-next-line @typescript-eslint/prefer-promise-reject-errors
reject(`Unsupported data for createImageBitmap.`);
});
}

if (image instanceof Blob) {
const data = await image.arrayBuffer();
return this._engine.createImageBitmap(data);
}

throw new Error("Unsupported data for createImageBitmap.");
}

/**
Expand Down