Skip to content

Conversation

@AdyenAutomationBot
Copy link
Collaborator

@AdyenAutomationBot AdyenAutomationBot commented Oct 31, 2025

@gemini-code-assist
Copy link

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a routine version bump, updating the adyen-python-api-library to version 14.0.1. The primary purpose is to reflect the integration of recent changes, including those from PR #366, and to prepare for a new official release of the library.

Highlights

  • Version Update: The library version has been incremented from 14.0.0 to 14.0.1 across all relevant configuration files.
  • New Release Preparation: This pull request prepares the adyen-python-api-library for a new release, incorporating previously merged changes, specifically from pull request chore(deps): update dependency python to 3.14 #366.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@sonarqubecloud
Copy link

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the library version to 14.0.1 across Adyen/settings.py, VERSION, and setup.py. While the version update is consistent, the process of manually updating the version in multiple files is error-prone. I've added a comment with a suggestion to refactor this to use a single source of truth for the version number, which will improve maintainability for future releases.

name='Adyen',
packages=find_packages(include=["Adyen*"], exclude=["tests", "tests.*"]),
version='14.0.0',
version='14.0.1',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The library version is hardcoded in multiple files (setup.py, Adyen/settings.py, and VERSION). This practice is error-prone, as it's easy to forget to update the version in all locations, leading to inconsistencies.

To improve maintainability, I recommend using a single source of truth for the version number. For instance, you could define the version in Adyen/settings.py and then read it dynamically in setup.py. The VERSION file could either be removed or generated automatically as part of your release process.

Here's an example of how you could modify setup.py to read the version from Adyen/settings.py:

# At the top of setup.py
import re
import os
from setuptools import setup, find_packages

here = os.path.abspath(os.path.dirname(__file__))
# Read the version number from a single source of truth
with open(os.path.join(here, 'Adyen', 'settings.py'), 'r') as f:
    version = re.search(
        r"^LIB_VERSION\s*=\s*['\"]([^'\"]*)['\"]",
        f.read(),
        re.MULTILINE
    ).group(1)

setup(
    name='Adyen',
    packages=find_packages(include=["Adyen*"], exclude=["tests", "tests.*"]), 
    version=version,
    # ... rest of setup
)

This change would make your versioning more robust and easier to manage for future releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants