-
Notifications
You must be signed in to change notification settings - Fork 47
Release v14.0.1 #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Release v14.0.1 #396
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a routine version bump, updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
1817d5a to
9f1b5d6
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the library version to 14.0.1 across Adyen/settings.py, VERSION, and setup.py. While the version update is consistent, the process of manually updating the version in multiple files is error-prone. I've added a comment with a suggestion to refactor this to use a single source of truth for the version number, which will improve maintainability for future releases.
| name='Adyen', | ||
| packages=find_packages(include=["Adyen*"], exclude=["tests", "tests.*"]), | ||
| version='14.0.0', | ||
| version='14.0.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The library version is hardcoded in multiple files (setup.py, Adyen/settings.py, and VERSION). This practice is error-prone, as it's easy to forget to update the version in all locations, leading to inconsistencies.
To improve maintainability, I recommend using a single source of truth for the version number. For instance, you could define the version in Adyen/settings.py and then read it dynamically in setup.py. The VERSION file could either be removed or generated automatically as part of your release process.
Here's an example of how you could modify setup.py to read the version from Adyen/settings.py:
# At the top of setup.py
import re
import os
from setuptools import setup, find_packages
here = os.path.abspath(os.path.dirname(__file__))
# Read the version number from a single source of truth
with open(os.path.join(here, 'Adyen', 'settings.py'), 'r') as f:
version = re.search(
r"^LIB_VERSION\s*=\s*['\"]([^'\"]*)['\"]",
f.read(),
re.MULTILINE
).group(1)
setup(
name='Adyen',
packages=find_packages(include=["Adyen*"], exclude=["tests", "tests.*"]),
version=version,
# ... rest of setup
)This change would make your versioning more robust and easier to manage for future releases.



Merged pull requests to be released:
Full Changelog: v14.0.0...main