Fix: CORS Misconfiguration with Wildcard Origin #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Fix Implementation
This PR addresses the high-severity CORS misconfiguration vulnerability identified in issue #348.
Changes Made
Security Improvements
Files Modified
Code Changes
Before (Vulnerable)
ypescript // VULNERABLE CODE await app.register(cors, { origin: true, // Allows all origins credentials: true, // Enables credentials methods: ['GET', 'POST', 'PUT', 'DELETE', 'PATCH'], allowedHeaders: ['Content-Type', 'Authorization', 'X-Requested-With'] });After (Fixed)
ypescript // FIXED CODE - Strict CORS configuration await app.register(cors, { origin: [ 'https://aixblock.com', 'https://www.aixblock.com', 'https://app.aixblock.com' ], credentials: true, methods: ['GET', 'POST', 'PUT', 'DELETE', 'PATCH'], allowedHeaders: ['Content-Type', 'Authorization', 'X-Requested-With'], optionsSuccessStatus: 200 });Impact
Researcher: grich88 (j.grant.richards@proton.me)
Closes #348