dummy service: support usage without lib

Author: zardoy

typescript/src/dummyLanguageService.ts

@@ -1,20 +1,27 @@
 // only for basic testing, as vscode is actually using server
 import ts from 'typescript/lib/tsserverlibrary'
+import path from 'path'
 
-export const createLanguageService = (files: Record<string, string>) => {
+export const createLanguageService = (files: Record<string, string>, { useLib = true }: { useLib?: boolean } = {}) => {
     let dummyVersion = 1
+    let defaultLibDir: string | undefined
     const languageService = ts.createLanguageService({
         getProjectVersion: () => dummyVersion.toString(),
         getScriptVersion: () => dummyVersion.toString(),
         getCompilationSettings: () => ({ allowJs: true, jsx: ts.JsxEmit.Preserve, target: ts.ScriptTarget.ESNext }),
         getScriptFileNames: () => Object.keys(files),
         getScriptSnapshot: fileName => {
-            const contents = files[fileName]
+            let contents = files[fileName]
+            if (useLib && path.dirname(fileName) === defaultLibDir) contents = ts.sys.readFile(fileName)
             if (contents === undefined) return
             return ts.ScriptSnapshot.fromString(contents)
         },
         getCurrentDirectory: () => '',
-        getDefaultLibFileName: () => require.resolve('typescript/lib/lib.esnext.full.d.ts'),
+        getDefaultLibFileName: options => {
+            const defaultLibPath = ts.getDefaultLibFilePath(options)
+            defaultLibDir = path.dirname(defaultLibPath)
+            return defaultLibPath
+        },
         fileExists(path) {
             return path in files
         },

typescript/test/completions.spec.ts

@@ -101,11 +101,18 @@ test('Not banned positions for our method snippets', () => {
     }
 })
 
-test.skip('Remove Useless Function Props', () => {
-    const [pos] = newFileContents(/* ts */ `
+test('Function props: cleans & highlights', () => {
+    const [pos, pos2] = newFileContents(/* ts */ `
         function fn() {}
         fn./*|*/
+        let a: {
+            (): void
+            sync: 5
+        }
+        a./*|*/
     `)
-    console.log(getCompletionsAtPosition(pos!)?.entries)
-    // expect(entryNames).not.includes('bind')
+    const entryNames = getCompletionsAtPosition(pos!)?.entryNames
+    expect(entryNames).not.includes('Symbol')
+    const entryNamesHighlighted = getCompletionsAtPosition(pos2!)?.entryNames
+    expect(entryNamesHighlighted).includes('☆sync')
 })