minor fixes docs + replaceSuggestions

Author: zardoy

README.MD

@@ -92,9 +92,11 @@ You can quickly disable this plugin functionality by setting this setting to fal
 
 ### Vue Support
 
-`.vue` SFC files support is enabled out of the box when [Vue Language Features (Volar)](https://marketplace.visualstudio.com/items?itemName=Vue.volar) is installed.
+`.vue` SFC files support is disabled, but can be enabled with setting and when [Vue Language Features (Volar)](https://marketplace.visualstudio.com/items?itemName=Vue.volar) is installed.
 
-For the first time, it will configure `volar.vueserver.configFilePath` setting, to disable Vue support use `"tsEssentialPlugins.enableVueSupport": true` setting.
+Enable now: `"tsEssentialPlugins.enableVueSupport": true` (if you're not using local `./volar.config.js`)
+
+For the first time, it will configure `volar.vueserver.configFilePath` setting.
 
 This also makes plugin work in Volar's takeover mode!
 

src/configurationType.ts

@@ -6,16 +6,21 @@ type ReplaceRule = {
      * e.g. `readFile`, `^readFile` (global) or `fs.readFile`
      */
     suggestion: string
+    /**
+     * Also its possible to specify any other completion properties. For example:
+     * - sourceDisplay
+     */
     filter?: {
         kind?: keyof Record<ScriptElementKind, string>
-        /** doesn't support globs and not generally recommended */
-        sourceDisplay?: boolean
         fileNamePattern?: string
         languageMode?: keyof typeof ScriptKind
     }
-    /** by default only one entry is being proccessed */
+    /** by default only first entry is proccessed */
     processMany?: boolean
     delete?: boolean
+    /**
+     * - true - original suggestion will be shown below current
+     */
     duplicateOriginal?: boolean | 'above'
     patch?: Partial<{
         name: string

typescript/src/completionsAtPosition.ts

@@ -216,7 +216,7 @@ export const getCompletionsAtPosition = (
 
     if (c('improveJsxCompletions') && leftNode) prior.entries = improveJsxCompletions(prior.entries, leftNode, position, sourceFile, c('jsxCompletionsMap'))
 
-    const processedEntryIdxs: number[] = []
+    const processedEntries = new Set<ts.CompletionEntry>()
     for (const rule of c('replaceSuggestions')) {
         if (rule.filter?.fileNamePattern) {
             // todo replace with something better
@@ -242,8 +242,9 @@ export const getCompletionsAtPosition = (
             // todo-low (perf debt) clone probably should be used this
             const entry = prior!.entries[entryIndex]!
             if (rule.duplicateOriginal) {
-                processedEntryIdxs.push(entryIndex + 1)
-                prior!.entries.splice(rule.duplicateOriginal === 'above' ? entryIndex : entryIndex + 1, 0, { ...entry })
+                const duplicateEntry = { ...entry }
+                prior!.entries.splice(rule.duplicateOriginal === 'above' ? entryIndex : entryIndex + 1, 0, duplicateEntry)
+                processedEntries.add(duplicateEntry)
             }
 
             const { patch } = rule
@@ -259,12 +260,11 @@ export const getCompletionsAtPosition = (
                 entry.insertText = entry.name
             }
             if (rule.patch?.insertText) entry.isSnippet = true
-            processedEntryIdxs.push(entryIndex)
-            prior!.entries.splice(entryIndex, 1, entry)
+            processedEntries.add(entry)
         }
 
         entry: for (const [i, entry] of prior!.entries.entries()) {
-            if (processedEntryIdxs.includes(i)) continue
+            if (processedEntries.has(entry)) continue
             const { name } = entry
             if (!nameComparator(name)) continue
             const { fileNamePattern, languageMode, ...simpleEntryFilters } = rule.filter ?? {}