Skip to content

Set proper exit code when cpplint.py detects lint errors. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set proper exit code when cpplint.py detects lint errors. #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,16 @@ function runner(options, next) {

/*jslint unparam:true*/
exec(args.join(' ').trim(), function (err, stdout, stderr) {

return parseOutput(stderr, next);
}).on('exit', function (exitCode) {
process.exitCode = exitCode;
});
/*jslint unparam:false*/
});
}

process.on('exit', function () {
process.exit(process.exitCode);
Copy link

@MiniGod MiniGod Feb 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to do this. Setting process.exitCode above is enough.

https://nodejs.org/docs/latest/api/process.html#process_process_exitcode

process.exitCode
A number which will be the process exit code, when the process [...] exits gracefully

Copy link
Author

@agirorn agirorn Mar 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On node.js 0.10 this is required.

Copy link
Collaborator

@gdams gdams Apr 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agirorn I suggest that your remove this now as node.js 0.10 is long out of support, The we should look at getting this landed

});

module.exports = runner;
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,9 @@
},
"devDependencies": {
"grunt": "~0.4.1",
"grunt-cli": "^1.2.0",
"grunt-jslint": "~1.1.12",
"vows": "~0.7.0",
"grunt-vows": "~0.4.0"
"grunt-vows": "~0.4.0",
"vows": "~0.7.0"
}
}