Pass though non-numbers

Author: razor-x

src/lib/parse.test.ts

@@ -23,12 +23,3 @@ test('parseUrlSearchParams: with URLSearchParams input', (t) => {
     'with URLSearchParams input',
   )
 })
-
-test.todo('pass though number values that parse as NaN')
-test.todo(
-  'pass though boolean values that do not parse as truthy or falsy values',
-)
-
-// e.g., foo.bar= would conflict with foo.bar.a= or foo.bar.b=2
-// since this would be a null object containing values (null is still a value).
-test.todo('cannot parse conflicting object keys')

src/lib/parse.ts

@@ -65,8 +65,10 @@ const parse = (k: string, values: string[], type: ValueType): unknown => {
 
 const parseNumber = (v: string): number | null | string => {
   if (v.length === 0) return null
+  if (v === 'Infinity' || v === '-Infinity') return v
   const n = Number(v)
   if (isNaN(n)) return v
+  if (n === Infinity || n === -Infinity) return v
   return n
 }
 

test/edge-cases.test.ts

@@ -0,0 +1,32 @@
+import test from 'ava'
+import { z } from 'zod'
+
+import { parseUrlSearchParams } from '@seamapi/url-search-params-parser'
+
+test('pass though number values that do not parse as number', (t) => {
+  t.deepEqual(parseUrlSearchParams('foo=a', z.object({ foo: z.number() })), {
+    foo: 'a',
+  })
+  t.deepEqual(parseUrlSearchParams('foo=NaN', z.object({ foo: z.number() })), {
+    foo: 'NaN',
+  })
+  t.deepEqual(
+    parseUrlSearchParams('foo=Infinity', z.object({ foo: z.number() })),
+    {
+      foo: 'Infinity',
+    },
+  )
+  t.deepEqual(
+    parseUrlSearchParams('foo=-Infinity', z.object({ foo: z.number() })),
+    {
+      foo: '-Infinity',
+    },
+  )
+})
+test.todo(
+  'pass though boolean values that do not parse as truthy or falsy values',
+)
+
+// e.g., foo.bar= would conflict with foo.bar.a= or foo.bar.b=2
+// since this would be a null object containing values (null is still a value).
+test.todo('cannot parse conflicting object keys')