Skip to content

LICENSE inconsistency across the repo. #365

@KushalMeghani1644

Description

@KushalMeghani1644

While looking through the repository I found a few inconsistencies regarding the LICENSE of the crate...

What I found:

  1. The README states:

“Unless you explicitly state otherwise, any contribution intentionally submitted for inclusion in the work by you, as defined in the Apache-2.0 license, shall be dual licensed as above…”

However:

  • There is no LICENSE or LICENSES/ directory in the repository root.

  • The crates in this workspace do not share a single license — some are ISC, some are MIT OR Apache-2.0.

  • Here is the output of a license scan across all Cargo.toml files:

grep -R --include="Cargo.toml" -n 'license\s*=' .

./riscv-pac/Cargo.toml:12:license = "ISC"
./riscv-peripheral/Cargo.toml:12:license = "ISC"
./riscv-rt/Cargo.toml:11:license = "ISC"
./riscv-rt/macros/Cargo.toml:10:license = "MIT OR Apache-2.0"
./riscv-semihosting/Cargo.toml:11:license = "MIT OR Apache-2.0"
./riscv-target-parser/Cargo.toml:11:license = "ISC"
./riscv/Cargo.toml:12:license = "ISC"

Why this is a problem:

  • The README suggests Apache-2.0 dual licensing, but most crates are actually ISC.

  • Two crates do use MIT OR Apache-2.0, so the repo is mixed-licensed.

Suggested fix:

  • We can include a LICENSE.md and state in the README clearly with what LICENSE the repo uses.

Thank you

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions