-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-141376: Rename _AsyncioDebug to _Py_AsyncioDebug #141391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@pablogsal, you probably know the compilation magic here. Can we change the name? |
vstinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes, as long as we don't change the name of the section where it ends. If the tests pass (and are executed) we are good 👍 |
I had never heard of that requirement, OOI how would symbols exported from vendored libs such as mimalloc be handled? |
They are not exported in the dynamic table. What @encukou is talking about is the symbols we export in the dynamic table of either the executable of the |
This is an exported symbol; it should have our prefix.
Pyprefix #141376