Skip to content

Conversation

@encukou
Copy link
Member

@encukou encukou commented Nov 11, 2025

This is an exported symbol; it should have our prefix.

@encukou
Copy link
Member Author

encukou commented Nov 11, 2025

@pablogsal, you probably know the compilation magic here. Can we change the name?

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal
Copy link
Member

@pablogsal, you probably know the compilation magic here. Can we change the name?

Yes, as long as we don't change the name of the section where it ends. If the tests pass (and are executed) we are good 👍

@kumaraditya303
Copy link
Contributor

This is an exported symbol; it should have our prefix.

I had never heard of that requirement, OOI how would symbols exported from vendored libs such as mimalloc be handled?

@pablogsal
Copy link
Member

pablogsal commented Nov 11, 2025

how would symbols exported from vendored libs such as mimalloc be handled?

They are not exported in the dynamic table. What @encukou is talking about is the symbols we export in the dynamic table of either the executable of the libpython.so. These are the symbols you can link against. The 3rd party ones or the mimalloc ones don't end there unless I have missed something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants