gh-140824: Implement the math package in Python #141363
Open
+85
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the 'math' extension to '_math'.
vstinner
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
AA-Turner
requested changes
Nov 10, 2025
Comment on lines
+7
to
+8
| # gh-140824: Fix module name for pickle | ||
| def patch_module(objs, module): |
Member
There was a problem hiding this comment.
Would it be better just to have the module name as math.integer for these functions in C?
Member
Author
There was a problem hiding this comment.
In C, function.__module__ is set to the extension name: so set to _math or _math_integer. The whole purpose of this PR is to fix function.__module__.
|
When you're done making the requested changes, leave the comment: |
AA-Turner
reviewed
Nov 10, 2025
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Member
Author
|
@AA-Turner: I addressed your review. Please review the updated PR. |
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
This is still a hack. I think there should be more straightforward way.
AA-Turner
reviewed
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the 'math' extension to '_math'.