Fix memory leak by removing custom net/tls polyfills #1109
+3
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Workers now provide built-in net and tls polyfills, making custom polyfills unnecessary and fixing memory leaks caused by the previous Socket polyfill implementation.
porsager
force-pushed
the
master
branch
2 times, most recently
from
4a0fe34 to
3a43815
Compare
Owner
|
Fantastic ! Do you have any idea for running the tests for Cloudflare Workers too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Custom Socket polyfill implementation was causing memory leaks in Cloudflare Workers environments.
Solution
Removed custom net/tls polyfills since Cloudflare Workers now provide built-in polyfills for these modules.
Changes
Result
Reproducer: https://github.com/astralhpi/cf-worker-memory-leak-sample