ENH: add dtype_from_format option to preserve Excel text formatting #63037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
Nov 11, 2025
Member
There was a problem hiding this comment.
Thanks for the PR. Overall, this seems far too complex an implementation for the feature being implemented. Why can we not just determine the format upon reading each cell and react appropriately?
In addition, it does not seem to me pandas should ever read a cell as numeric if that cell is text. I think we should not implement this as a flag.
| ordered_levels.append(level_idx) | ||
| return ordered_levels | ||
|
|
||
| def _convert_index_labels(self, index, levels_to_convert: list[int]): |
Member
There was a problem hiding this comment.
It looks like code got duplicated?
| ordered_levels.append(level_idx) | ||
| return ordered_levels | ||
|
|
||
| def _convert_index_labels(self, index, levels_to_convert: list[int]): |
Comment on lines
+3342
to
+3344
| This behavior currently applies to the ``openpyxl`` and ``xlrd`` engines. Other | ||
| engines simply ignore the flag until text format detection is implemented for | ||
| them. |
Member
There was a problem hiding this comment.
I'm negative on diverging behavior between readers unless absolutely necessary.
Comment on lines
+1003
to
+1014
| @staticmethod | ||
| def _parser_engine(parser): | ||
| return getattr(parser, "_engine", parser) | ||
|
|
||
| @classmethod | ||
| def _parser_attr(cls, parser, attribute: str): | ||
| if hasattr(parser, attribute): | ||
| return getattr(parser, attribute) | ||
| engine = cls._parser_engine(parser) | ||
| if engine is not parser and hasattr(engine, attribute): | ||
| return getattr(engine, attribute) | ||
| return None |
|
|
||
| @staticmethod | ||
| def _cell_is_text_formatted(cell) -> bool: | ||
| number_format = getattr(cell, "number_format", None) |
Member
There was a problem hiding this comment.
When does cell have and not have the number_format attribute?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.