-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
Move chained assignment detection to cython for Python 3.14 compat #62070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move chained assignment detection to cython for Python 3.14 compat #62070
Conversation
|
Some commented-out code needs to be removed, otherwise looks nice |
66cd359 to
efea93f
Compare
|
Can you merge main to see if that fixes the ci |
…ill skips check for inplace methods
|
Only remaining failure is the free-threaded build, where a bunch of tests fail with a missing warning, because the check in cython does not seem to work for free-threaded python (https://github.com/pandas-dev/pandas/actions/runs/18678375696/job/53253518246?pr=62070). To move forward with this PR, will include "3.14+ and freethreaded" condition to the |
|
Is this ready? |
|
@mroeschke any idea if this is ready? |
|
Discussed at today's dev call. This is working except for the free-threading build. We're going to merge this and follow up with a fix for the freethreading build when a solution presents itself. |
|
thanks @jorisvandenbossche |
Draft exploring a solution for #61368