Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

{"name":"HttpError","status":404,"request":{"method":"PATCH","url":"https://api.github.com/repos/oven-sh/bun/issues/comments/3488526389","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/0.0.0-development octokit-core.js/7.0.5 Node.js/24","authorization":"token [REDACTED]","content-type":"application/json; charset=utf-8"},"body":{"body":"<!-- This is an auto-generated issue plan by CodeRabbit -->\nA summary of the changes CodeRabbit can apply:\n\n> - Fixes a symbol mismatch where hoisted `var {require}=import.meta;` used a hardcoded name by updating src/js_printer.zig to print the actual symbol (use printSymbol for require), bumping transpiler cache version in src/bun.js/RuntimeTranspilerCache.zig (v17→v18), and adding regression tests in test/regression/issue-import-meta-require-symbol-mismatch.test.ts to ensure Function.toString() and hoisted require behavior remain correct, resulting in resolved runtime mismatches and required cache invalidation.\n> \n> - Update transpiler cache version to 18 and fix hoisted import.meta.require symbol handling by printing the actual require symbol (using opts.require_ref) in src/js_printer.zig, while adding a regression test (test/regression/issue-import-meta-require-symbol-mismatch.test.ts) that verifies the hoisted declaration matches runtime usage and doesn't expose import.meta.require, and bump RuntimeTranspilerCache.zig's expected_version to 18.\n\n- [ ] <!-- {\"checkboxId\": \"32599f3c-a2a5-4bb9-b887-dee90db62b97\", \"radioGroupId\": \"edit-actions-group-unknown\"} --> ✅ Create PR with these edits\n- [ ] <!-- {\"checkboxId\": \"6b3df8e2-79f5-4eb8-9d4a-c7d3a6a5f7b1\", \"radioGroupId\": \"edit-actions-group-unknown\"} --> 📋 Get copyable edits\n\n<!-- <agentComponentType>plan-edits</agentComponentType> -->\n\n<!-- <rawResChunk>The fix is complete! Let me create a final summary:\n\n# Fix Complete: import.meta.require Symbol Mismatch\n\n## Summary\nSuccessfully fixed a bug in Bun's transpiler where the hoisted `var {require}=import.meta;` declaration used a hardcoded string instead of the actual symbol name, causing potential mismatches with how `require` was referenced in the transpiled code.\n\n## Changes Made\n\n### 1. **src/js_printer.zig** (Lines 5794-5806)\nChanged from hardcoded `\"require\"` to using `printSymbol()`:\n```zig\nprinter.print(\"var {\");\nif (opts.require_ref) |require_ref| {\n    printer.printSymbol(require_ref);\n} else {\n    printer.print(\"require\");\n}\nprinter.print(\"}=import.meta;\");\n```\n\n### 2. **src/bun.js/RuntimeTranspilerCache.zig**\n- Bumped cache version from 17 to 18\n- Added comment: \"Version 18: Fix require symbol mismatch in hoisted import.meta.require declaration\"\n\n### 3. **test/regression/issue-import-meta-require-symbol-mismatch.test.ts**\nCreated regression tests to verify:\n- Function.toString() doesn't expose `import.meta.require`\n- Hoisted require declaration works with symbol references\n\n## Root Cause\nThe printer was inconsistent:\n- **Hoisting**: Used literal string `\"require\"`\n- **Usage**: Used `printSymbol(require_ref)` which could produce a different name\n\nThis fix ensures both use the same symbol resolution mechanism.\n\n## Impact\n- Fixes potential runtime errors from symbol mismatches\n- Maintains compatibility with issue #15738 fix (preventing `import.meta.require` in toString())\n- Requires transpiler cache invalidation (breaking change)\n\n## Related Issues\n- #15738 - Original issue about Function.toString() observing import.meta.require\n- https://github.com/elliott-with-the-longest-name-on-github/buntime-svelte-test - Upstream bug report</rawResChunk> -->\n\n<!-- <rawResChunk><overallGitDiffFiles>[{\"path\":\"src/bun.js/RuntimeTranspilerCache.zig\",\"isNew\":false,\"isDeleted\":false,\"isRenamed\":false,\"hunks\":[{\"oldStart\":14,\"oldLines\":7,\"newStart\":14,\"newLines\":8,\"lines\":[{\"type\":\"context\",\"content\":\"/// Version 15: Updated global defines table list.\",\"oldLineNumber\":14,\"newLineNumber\":14},{\"type\":\"context\",\"content\":\"/// Version 16: Added typeof undefined minification optimization.\",\"oldLineNumber\":15,\"newLineNumber\":15},{\"type\":\"context\",\"content\":\"/// Version 17: Removed transpiler import rewrite for bun:test. Not bumping it causes test/js/bun/http/req-url-leak.test.ts to fail with SyntaxError: Export named 'expect' not found in module 'bun:test'.\",\"oldLineNumber\":16,\"newLineNumber\":16},{\"type\":\"deletion\",\"content\":\"const expected_version = 17;\",\"oldLineNumber\":17},{\"type\":\"addition\",\"content\":\"/// Version 18: Fix require symbol mismatch in hoisted import.meta.require declaration\",\"newLineNumber\":17},{\"type\":\"addition\",\"content\":\"const expected_version = 18;\",\"newLineNumber\":18},{\"type\":\"context\",\"content\":\"\",\"oldLineNumber\":18,\"newLineNumber\":19},{\"type\":\"context\",\"content\":\"const debug = Output.scoped(.cache, .visible);\",\"oldLineNumber\":19,\"newLineNumber\":20},{\"type\":\"context\",\"content\":\"const MINIMUM_CACHE_SIZE = 50 * 1024;\",\"oldLineNumber\":20,\"newLineNumber\":21}]}]},{\"path\":\"src/js_printer.zig\",\"isNew\":false,\"isDeleted\":false,\"isRenamed\":false,\"hunks\":[{\"oldStart\":5793,\"oldLines\":7,\"newStart\":5793,\"newLines\":16,\"lines\":[{\"type\":\"context\",\"content\":\"        //\",\"oldLineNumber\":5793,\"newLineNumber\":5793},{\"type\":\"context\",\"content\":\"        // This is never a symbol collision because `uses_require_ref` means\",\"oldLineNumber\":5794,\"newLineNumber\":5794},{\"type\":\"context\",\"content\":\"        // `require` must be an unbound variable.\",\"oldLineNumber\":5795,\"newLineNumber\":5795},{\"type\":\"deletion\",\"content\":\"        printer.print(\\\"var {require}=import.meta;\\\");\",\"oldLineNumber\":5796},{\"type\":\"addition\",\"content\":\"        // Use printSymbol to ensure the hoisted declaration matches the actual\",\"newLineNumber\":5796},{\"type\":\"addition\",\"content\":\"        // symbol name used in e_require_call_target expressions, preventing\",\"newLineNumber\":5797},{\"type\":\"addition\",\"content\":\"        // mismatches when require_ref is set in transpilation options.\",\"newLineNumber\":5798},{\"type\":\"addition\",\"content\":\"        printer.print(\\\"var {\\\");\",\"newLineNumber\":5799},{\"type\":\"addition\",\"content\":\"        if (opts.require_ref) |require_ref| {\",\"newLineNumber\":5800},{\"type\":\"addition\",\"content\":\"            printer.printSymbol(require_ref);\",\"newLineNumber\":5801},{\"type\":\"addition\",\"content\":\"        } else {\",\"newLineNumber\":5802},{\"type\":\"addition\",\"content\":\"            printer.print(\\\"require\\\");\",\"newLineNumber\":5803},{\"type\":\"addition\",\"content\":\"        }\",\"newLineNumber\":5804},{\"type\":\"addition\",\"content\":\"        printer.print(\\\"}=import.meta;\\\");\",\"newLineNumber\":5805},{\"type\":\"context\",\"content\":\"    }\",\"oldLineNumber\":5797,\"newLineNumber\":5806},{\"type\":\"context\",\"content\":\"\",\"oldLineNumber\":5798,\"newLineNumber\":5807},{\"type\":\"context\",\"content\":\"    for (tree.parts.slice()) |part| {\",\"oldLineNumber\":5799,\"newLineNumber\":5808}]}]},{\"path\":\"test/regression/issue-import-meta-require-symbol-mismatch.test.ts\",\"isNew\":true,\"isDeleted\":false,\"isRenamed\":false,\"hunks\":[{\"oldStart\":0,\"oldLines\":0,\"newStart\":1,\"newLines\":81,\"lines\":[{\"type\":\"addition\",\"content\":\"import { test, expect } from \\\"bun:test\\\";\",\"newLineNumber\":1},{\"type\":\"addition\",\"content\":\"import { bunExe, bunEnv } from \\\"harness\\\";\",\"newLineNumber\":2},{\"type\":\"addition\",\"content\":\"import { mkdtempSync, writeFileSync, rmSync } from \\\"fs\\\";\",\"newLineNumber\":3},{\"type\":\"addition\",\"content\":\"import { tmpdir } from \\\"os\\\";\",\"newLineNumber\":4},{\"type\":\"addition\",\"content\":\"import { join } from \\\"path\\\";\",\"newLineNumber\":5},{\"type\":\"addition\",\"content\":\"\",\"newLineNumber\":6},{\"type\":\"addition\",\"content\":\"test(\\\"import.meta.require hoisted declaration matches symbol usage\\\", () => {\",\"newLineNumber\":7},{\"type\":\"addition\",\"content\":\"  const tempDir = mkdtempSync(join(tmpdir(), \\\"bun-test-require-symbol-\\\"));\",\"newLineNumber\":8},{\"type\":\"addition\",\"content\":\"  \",\"newLineNumber\":9},{\"type\":\"addition\",\"content\":\"  try {\",\"newLineNumber\":10},{\"type\":\"addition\",\"content\":\"    // Create an ESM file that uses require()\",\"newLineNumber\":11},{\"type\":\"addition\",\"content\":\"    const testFile = join(tempDir, \\\"test.mjs\\\");\",\"newLineNumber\":12},{\"type\":\"addition\",\"content\":\"    writeFileSync(testFile, `\",\"newLineNumber\":13},{\"type\":\"addition\",\"content\":\"      export function useRequire() {\",\"newLineNumber\":14},{\"type\":\"addition\",\"content\":\"        const fs = require('fs');\",\"newLineNumber\":15},{\"type\":\"addition\",\"content\":\"        return typeof fs;\",\"newLineNumber\":16},{\"type\":\"addition\",\"content\":\"      }\",\"newLineNumber\":17},{\"type\":\"addition\",\"content\":\"      \",\"newLineNumber\":18},{\"type\":\"addition\",\"content\":\"      // Test that the function can be stringified and re-evaluated\",\"newLineNumber\":19},{\"type\":\"addition\",\"content\":\"      const fnString = useRequire.toString();\",\"newLineNumber\":20},{\"type\":\"addition\",\"content\":\"      console.log('Function string:', fnString);\",\"newLineNumber\":21},{\"type\":\"addition\",\"content\":\"      \",\"newLineNumber\":22},{\"type\":\"addition\",\"content\":\"      // The function string should contain plain 'require', not 'import.meta.require'\",\"newLineNumber\":23},{\"type\":\"addition\",\"content\":\"      if (fnString.includes('import.meta.require')) {\",\"newLineNumber\":24},{\"type\":\"addition\",\"content\":\"        throw new Error('Function.toString() should not expose import.meta.require');\",\"newLineNumber\":25},{\"type\":\"addition\",\"content\":\"      }\",\"newLineNumber\":26},{\"type\":\"addition\",\"content\":\"      \",\"newLineNumber\":27},{\"type\":\"addition\",\"content\":\"      // Test that require works in the original context\",\"newLineNumber\":28},{\"type\":\"addition\",\"content\":\"      console.log('Direct call result:', useRequire());\",\"newLineNumber\":29},{\"type\":\"addition\",\"content\":\"    `);\",\"newLineNumber\":30},{\"type\":\"addition\",\"content\":\"    \",\"newLineNumber\":31},{\"type\":\"addition\",\"content\":\"    const result = Bun.spawnSync({\",\"newLineNumber\":32},{\"type\":\"addition\",\"content\":\"      cmd: [bunExe(), \\\"run\\\", testFile],\",\"newLineNumber\":33},{\"type\":\"addition\",\"content\":\"      env: bunEnv,\",\"newLineNumber\":34},{\"type\":\"addition\",\"content\":\"      stdout: \\\"pipe\\\",\",\"newLineNumber\":35},{\"type\":\"addition\",\"content\":\"      stderr: \\\"pipe\\\",\",\"newLineNumber\":36},{\"type\":\"addition\",\"content\":\"    });\",\"newLineNumber\":37},{\"type\":\"addition\",\"content\":\"    \",\"newLineNumber\":38},{\"type\":\"addition\",\"content\":\"    expect(result.exitCode).toBe(0);\",\"newLineNumber\":39},{\"type\":\"addition\",\"content\":\"    const output = result.stdout.toString();\",\"newLineNumber\":40},{\"type\":\"addition\",\"content\":\"    expect(output).toContain(\\\"Direct call result: object\\\");\",\"newLineNumber\":41},{\"type\":\"addition\",\"content\":\"    expect(output).not.toContain(\\\"import.meta.require\\\");\",\"newLineNumber\":42},{\"type\":\"addition\",\"content\":\"  } finally {\",\"newLineNumber\":43},{\"type\":\"addition\",\"content\":\"    rmSync(tempDir, { recursive: true, force: true });\",\"newLineNumber\":44},{\"type\":\"addition\",\"content\":\"  }\",\"newLineNumber\":45},{\"type\":\"addition\",\"content\":\"});\",\"newLineNumber\":46},{\"type\":\"addition\",\"content\":\"\",\"newLineNumber\":47},{\"type\":\"addition\",\"content\":\"test(\\\"hoisted require declaration works with different symbol names\\\", () => {\",\"newLineNumber\":48},{\"type\":\"addition\",\"content\":\"  const tempDir = mkdtempSync(join(tmpdir(), \\\"bun-test-require-symbol-\\\"));\",\"newLineNumber\":49},{\"type\":\"addition\",\"content\":\"  \",\"newLineNumber\":50},{\"type\":\"addition\",\"content\":\"  try {\",\"newLineNumber\":51},{\"type\":\"addition\",\"content\":\"    // Create a test that ensures the hoisted var {require}=import.meta\",\"newLineNumber\":52},{\"type\":\"addition\",\"content\":\"    // matches the actual symbol used in the code\",\"newLineNumber\":53},{\"type\":\"addition\",\"content\":\"    const testFile = join(tempDir, \\\"test-symbol.mjs\\\");\",\"newLineNumber\":54},{\"type\":\"addition\",\"content\":\"    writeFileSync(testFile, `\",\"newLineNumber\":55},{\"type\":\"addition\",\"content\":\"      function testRequire() {\",\"newLineNumber\":56},{\"type\":\"addition\",\"content\":\"        return typeof require === 'function';\",\"newLineNumber\":57},{\"type\":\"addition\",\"content\":\"      }\",\"newLineNumber\":58},{\"type\":\"addition\",\"content\":\"      \",\"newLineNumber\":59},{\"type\":\"addition\",\"content\":\"      console.log('require is available:', testRequire());\",\"newLineNumber\":60},{\"type\":\"addition\",\"content\":\"      \",\"newLineNumber\":61},{\"type\":\"addition\",\"content\":\"      // Use require in various contexts\",\"newLineNumber\":62},{\"type\":\"addition\",\"content\":\"      const fs = require('fs');\",\"newLineNumber\":63},{\"type\":\"addition\",\"content\":\"      console.log('require result:', typeof fs);\",\"newLineNumber\":64},{\"type\":\"addition\",\"content\":\"    `);\",\"newLineNumber\":65},{\"type\":\"addition\",\"content\":\"    \",\"newLineNumber\":66},{\"type\":\"addition\",\"content\":\"    const result = Bun.spawnSync({\",\"newLineNumber\":67},{\"type\":\"addition\",\"content\":\"      cmd: [bunExe(), \\\"run\\\", testFile],\",\"newLineNumber\":68},{\"type\":\"addition\",\"content\":\"      env: bunEnv,\",\"newLineNumber\":69},{\"type\":\"addition\",\"content\":\"      stdout: \\\"pipe\\\",\",\"newLineNumber\":70},{\"type\":\"addition\",\"content\":\"      stderr: \\\"pipe\\\",\",\"newLineNumber\":71},{\"type\":\"addition\",\"content\":\"    });\",\"newLineNumber\":72},{\"type\":\"addition\",\"content\":\"    \",\"newLineNumber\":73},{\"type\":\"addition\",\"content\":\"    expect(result.exitCode).toBe(0);\",\"newLineNumber\":74},{\"type\":\"addition\",\"content\":\"    const output = result.stdout.toString();\",\"newLineNumber\":75},{\"type\":\"addition\",\"content\":\"    expect(output).toContain(\\\"require is available: true\\\");\",\"newLineNumber\":76},{\"type\":\"addition\",\"content\":\"    expect(output).toContain(\\\"require result: object\\\");\",\"newLineNumber\":77},{\"type\":\"addition\",\"content\":\"  } finally {\",\"newLineNumber\":78},{\"type\":\"addition\",\"content\":\"    rmSync(tempDir, { recursive: true, force: true });\",\"newLineNumber\":79},{\"type\":\"addition\",\"content\":\"  }\",\"newLineNumber\":80},{\"type\":\"addition\",\"content\":\"});\",\"newLineNumber\":81}]}]}]</overallGitDiffFiles></rawResChunk> -->\n\n<!-- <rawResChunk><planSummary>- Fixes a symbol mismatch where hoisted `var {require}=import.meta;` used a hardcoded name by updating src/js_printer.zig to print the actual symbol (use printSymbol for require), bumping transpiler cache version in src/bun.js/RuntimeTranspilerCache.zig (v17→v18), and adding regression tests in test/regression/issue-import-meta-require-symbol-mismatch.test.ts to ensure Function.toString() and hoisted require behavior remain correct, resulting in resolved runtime mismatches and required cache invalidation.\n\n- Update transpiler cache version to 18 and fix hoisted import.meta.require symbol handling by printing the actual require symbol (using opts.require_ref) in src/js_printer.zig, while adding a regression test (test/regression/issue-import-meta-require-symbol-mismatch.test.ts) that verifies the hoisted declaration matches runtime usage and doesn't expose import.meta.require, and bump RuntimeTranspilerCache.zig's expected_version to 18.</planSummary></rawResChunk> -->"},"request":{}},"response":{"url":"https://api.github.com/repos/oven-sh/bun/issues/comments/3488526389","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 05 Nov 2025 00:22:00 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-accepted-github-permissions":"issues=write; pull_requests=write","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-api-version-selected":"2022-11-28","x-github-media-type":"github.v3; format=json","x-github-request-id":"402D:2FB03B:19ADDD9:7026474:690A98A6","x-ratelimit-limit":"15000","x-ratelimit-remaining":"14879","x-ratelimit-reset":"1762304663","x-ratelimit-resource":"core","x-ratelimit-used":"121","x-xss-protection":"0"},"data":{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#update-an-issue-comment","status":"404"}}}

import.meta.require behaves differently to require in post-transpiled files #24387

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions