Add support to remove instruments

Author: atoulme

api/all/src/main/java/io/opentelemetry/api/metrics/DefaultMeter.java

@@ -75,6 +75,12 @@ public void add(long value, Attributes attributes) {}
 
     @Override
     public void add(long value) {}
+
+    @Override
+    public void remove(Attributes attributes) {}
+
+    @Override
+    public void remove(Attributes attributes, Context context) {}
   }
 
   private static class NoopDoubleCounter implements DoubleCounter {
@@ -86,6 +92,12 @@ public void add(double value, Attributes attributes) {}
 
     @Override
     public void add(double value) {}
+
+    @Override
+    public void remove(Attributes attributes) {}
+
+    @Override
+    public void remove(Attributes attributes, Context context) {}
   }
 
   private static class NoopLongCounterBuilder implements LongCounterBuilder {
@@ -167,6 +179,12 @@ public void add(long value, Attributes attributes) {}
 
     @Override
     public void add(long value) {}
+
+    @Override
+    public void remove(Attributes attributes) {}
+
+    @Override
+    public void remove(Attributes attributes, Context context) {}
   }
 
   private static class NoopDoubleUpDownCounter implements DoubleUpDownCounter {
@@ -178,6 +196,12 @@ public void add(double value, Attributes attributes) {}
 
     @Override
     public void add(double value) {}
+
+    @Override
+    public void remove(Attributes attributes) {}
+
+    @Override
+    public void remove(Attributes attributes, Context context) {}
   }
 
   private static class NoopLongUpDownCounterBuilder implements LongUpDownCounterBuilder {
@@ -261,6 +285,12 @@ public void record(double value, Attributes attributes) {}
 
     @Override
     public void record(double value) {}
+
+    @Override
+    public void remove(Attributes attributes) {}
+
+    @Override
+    public void remove(Attributes attributes, Context context) {}
   }
 
   private static class NoopLongHistogram implements LongHistogram {
@@ -272,6 +302,12 @@ public void record(long value, Attributes attributes) {}
 
     @Override
     public void record(long value) {}
+
+    @Override
+    public void remove(Attributes attributes) {}
+
+    @Override
+    public void remove(Attributes attributes, Context context) {}
   }
 
   private static class NoopDoubleHistogramBuilder implements DoubleHistogramBuilder {
@@ -365,6 +401,12 @@ public void set(double value, Attributes attributes) {}
 
     @Override
     public void set(double value, Attributes attributes, Context context) {}
+
+    @Override
+    public void remove(Attributes attributes) {}
+
+    @Override
+    public void remove(Attributes attributes, Context context) {}
   }
 
   private static class NoopLongGaugeBuilder implements LongGaugeBuilder {
@@ -406,6 +448,12 @@ public void set(long value, Attributes attributes) {}
 
     @Override
     public void set(long value, Attributes attributes, Context context) {}
+
+    @Override
+    public void remove(Attributes attributes) {}
+
+    @Override
+    public void remove(Attributes attributes, Context context) {}
   }
 
   private static class NoopObservableDoubleMeasurement implements ObservableDoubleMeasurement {

api/all/src/main/java/io/opentelemetry/api/metrics/DoubleCounter.java

@@ -45,4 +45,19 @@ public interface DoubleCounter {
    * @param context The explicit context to associate with this measurement.
    */
   void add(double value, Attributes attributes, Context context);
+
+  /**
+   * Remove the instrument.
+   *
+   * @param attributes A set of attributes to identify the instrument.
+   */
+  void remove(Attributes attributes);
+
+  /**
+   * Remove the instrument.
+   *
+   * @param attributes A set of attributes to identify the instrument.
+   * @param context The explicit context to associate with this measurement.
+   */
+  void remove(Attributes attributes, Context context);
 }

api/all/src/main/java/io/opentelemetry/api/metrics/DoubleGauge.java

@@ -39,4 +39,19 @@ public interface DoubleGauge {
    * @param context The explicit context to associate with this measurement.
    */
   void set(double value, Attributes attributes, Context context);
+
+  /**
+   * Remove the instrument.
+   *
+   * @param attributes A set of attributes to identify the instrument.
+   */
+  void remove(Attributes attributes);
+
+  /**
+   * Remove the instrument.
+   *
+   * @param attributes A set of attributes to identify the instrument.
+   * @param context The explicit context to associate with this measurement.
+   */
+  void remove(Attributes attributes, Context context);
 }

api/all/src/main/java/io/opentelemetry/api/metrics/DoubleHistogram.java

@@ -46,4 +46,19 @@ public interface DoubleHistogram {
    * @param context The explicit context to associate with this measurement.
    */
   void record(double value, Attributes attributes, Context context);
+
+  /**
+   * Remove the instrument.
+   *
+   * @param attributes A set of attributes to identify the instrument.
+   */
+  void remove(Attributes attributes);
+
+  /**
+   * Remove the instrument.
+   *
+   * @param attributes A set of attributes to identify the instrument.
+   * @param context The explicit context to associate with this measurement.
+   */
+  void remove(Attributes attributes, Context context);
 }

api/all/src/main/java/io/opentelemetry/api/metrics/DoubleUpDownCounter.java

@@ -45,4 +45,19 @@ public interface DoubleUpDownCounter {
    * @param context The explicit context to associate with this measurement.
    */
   void add(double value, Attributes attributes, Context context);
+
+  /**
+   * Remove the instrument.
+   *
+   * @param attributes A set of attributes to identify the instrument.
+   */
+  void remove(Attributes attributes);
+
+  /**
+   * Remove the instrument.
+   *
+   * @param attributes A set of attributes to identify the instrument.
+   * @param context The explicit context to associate with this measurement.
+   */
+  void remove(Attributes attributes, Context context);
 }

api/all/src/main/java/io/opentelemetry/api/metrics/LongCounter.java

@@ -46,4 +46,19 @@ public interface LongCounter {
    * @param context The explicit context to associate with this measurement.
    */
   void add(long value, Attributes attributes, Context context);
+
+  /**
+   * Remove the instrument.
+   *
+   * @param attributes A set of attributes to identify the instrument.
+   */
+  void remove(Attributes attributes);
+
+  /**
+   * Remove the instrument.
+   *
+   * @param attributes A set of attributes to identify the instrument.
+   * @param context The explicit context to associate with this measurement.
+   */
+  void remove(Attributes attributes, Context context);
 }

api/all/src/main/java/io/opentelemetry/api/metrics/LongGauge.java

@@ -39,4 +39,19 @@ public interface LongGauge {
    * @param context The explicit context to associate with this measurement.
    */
   void set(long value, Attributes attributes, Context context);
+
+  /**
+   * Remove the instrument.
+   *
+   * @param attributes A set of attributes to identify the instrument.
+   */
+  void remove(Attributes attributes);
+
+  /**
+   * Remove the instrument.
+   *
+   * @param attributes A set of attributes to identify the instrument.
+   * @param context The explicit context to associate with this measurement.
+   */
+  void remove(Attributes attributes, Context context);
 }

api/all/src/main/java/io/opentelemetry/api/metrics/LongHistogram.java

@@ -46,4 +46,19 @@ public interface LongHistogram {
    * @param context The explicit context to associate with this measurement.
    */
   void record(long value, Attributes attributes, Context context);
+
+  /**
+   * Remove the instrument.
+   *
+   * @param attributes A set of attributes to identify the instrument.
+   */
+  void remove(Attributes attributes);
+
+  /**
+   * Remove the instrument.
+   *
+   * @param attributes A set of attributes to identify the instrument.
+   * @param context The explicit context to associate with this measurement.
+   */
+  void remove(Attributes attributes, Context context);
 }

api/all/src/main/java/io/opentelemetry/api/metrics/LongUpDownCounter.java

@@ -45,4 +45,19 @@ public interface LongUpDownCounter {
    * @param context The explicit context to associate with this measurement.
    */
   void add(long value, Attributes attributes, Context context);
+
+  /**
+   * Remove the instrument.
+   *
+   * @param attributes A set of attributes to identify the instrument.
+   */
+  void remove(Attributes attributes);
+
+  /**
+   * Remove the instrument.
+   *
+   * @param attributes A set of attributes to identify the instrument.
+   * @param context The explicit context to associate with this measurement.
+   */
+  void remove(Attributes attributes, Context context);
 }

api/incubator/src/main/java/io/opentelemetry/api/incubator/metrics/ExtendedDefaultMeter.java

@@ -107,6 +107,12 @@ public void add(long value, Attributes attributes) {}
 
     @Override
     public void add(long value) {}
+
+    @Override
+    public void remove(Attributes attributes) {}
+
+    @Override
+    public void remove(Attributes attributes, Context context) {}
   }
 
   private static class NoopDoubleCounter implements ExtendedDoubleCounter {
@@ -123,6 +129,12 @@ public void add(double value, Attributes attributes) {}
 
     @Override
     public void add(double value) {}
+
+    @Override
+    public void remove(Attributes attributes) {}
+
+    @Override
+    public void remove(Attributes attributes, Context context) {}
   }
 
   private static class NoopLongCounterBuilder implements ExtendedLongCounterBuilder {
@@ -209,6 +221,12 @@ public void add(long value, Attributes attributes) {}
 
     @Override
     public void add(long value) {}
+
+    @Override
+    public void remove(Attributes attributes) {}
+
+    @Override
+    public void remove(Attributes attributes, Context context) {}
   }
 
   private static class NoopDoubleUpDownCounter implements ExtendedDoubleUpDownCounter {
@@ -225,6 +243,12 @@ public void add(double value, Attributes attributes) {}
 
     @Override
     public void add(double value) {}
+
+    @Override
+    public void remove(Attributes attributes) {}
+
+    @Override
+    public void remove(Attributes attributes, Context context) {}
   }
 
   private static class NoopLongUpDownCounterBuilder implements ExtendedLongUpDownCounterBuilder {
@@ -314,6 +338,12 @@ public void record(double value, Attributes attributes) {}
 
     @Override
     public void record(double value) {}
+
+    @Override
+    public void remove(Attributes attributes) {}
+
+    @Override
+    public void remove(Attributes attributes, Context context) {}
   }
 
   private static class NoopLongHistogram implements ExtendedLongHistogram {
@@ -330,6 +360,12 @@ public void record(long value, Attributes attributes) {}
 
     @Override
     public void record(long value) {}
+
+    @Override
+    public void remove(Attributes attributes) {}
+
+    @Override
+    public void remove(Attributes attributes, Context context) {}
   }
 
   private static class NoopDoubleHistogramBuilder implements ExtendedDoubleHistogramBuilder {
@@ -428,6 +464,12 @@ public void set(double value, Attributes attributes) {}
 
     @Override
     public void set(double value, Attributes attributes, Context context) {}
+
+    @Override
+    public void remove(Attributes attributes) {}
+
+    @Override
+    public void remove(Attributes attributes, Context context) {}
   }
 
   private static class NoopLongGaugeBuilder implements ExtendedLongGaugeBuilder {
@@ -474,6 +516,12 @@ public void set(long value, Attributes attributes) {}
 
     @Override
     public void set(long value, Attributes attributes, Context context) {}
+
+    @Override
+    public void remove(Attributes attributes) {}
+
+    @Override
+    public void remove(Attributes attributes, Context context) {}
   }
 
   private static class NoopObservableDoubleMeasurement implements ObservableDoubleMeasurement {