Skip to content

Commit dd2b211

Browse files
committed
pr review
1 parent bf82209 commit dd2b211

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/InstrumenterBuilder.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -493,6 +493,7 @@ private static <RESPONSE, REQUEST> void addThreadDetailsAttributeExtractor(
493493
if (instrumentationConfig != null
494494
&& instrumentationConfig
495495
.getStructured("java", empty())
496+
.getStructured("common", empty())
496497
.getStructured("thread_details", empty())
497498
.getBoolean("enabled", false)) {
498499
builder.addAttributesExtractor(new ThreadDetailsAttributesExtractor<>());

instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/AddThreadDetailsTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ private static OpenTelemetryConfigurationModel model(boolean enabled) {
8585
.withJava(
8686
new ExperimentalLanguageSpecificInstrumentationModel()
8787
.withAdditionalProperty(
88-
"thread_details", singletonMap("enabled", enabled)))));
88+
"common",
89+
singletonMap(
90+
"thread_details", singletonMap("enabled", enabled))))));
8991
}
9092
}

0 commit comments

Comments
 (0)