Skip to content

Commit 3b79cd1

Browse files
committed
Fix both SqlClient and DbClient extractors to capture network.type unconditionally
1 parent 5fd6bd8 commit 3b79cd1

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientAttributesExtractor.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,7 @@ public static <REQUEST, RESPONSE> AttributesExtractor<REQUEST, RESPONSE> create(
5757

5858
DbClientAttributesExtractor(DbClientAttributesGetter<REQUEST, RESPONSE> getter) {
5959
this.getter = getter;
60-
internalNetworkExtractor =
61-
new InternalNetworkAttributesExtractor<>(
62-
getter, SemconvStability.emitOldDatabaseSemconv(), false);
60+
internalNetworkExtractor = new InternalNetworkAttributesExtractor<>(getter, true, false);
6361
serverAttributesExtractor = ServerAttributesExtractor.create(getter);
6462
}
6563

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/SqlClientAttributesExtractor.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,7 @@ public static <REQUEST, RESPONSE> SqlClientAttributesExtractorBuilder<REQUEST, R
8787
// capturing query parameters disables statement sanitization
8888
this.statementSanitizationEnabled = !captureQueryParameters && statementSanitizationEnabled;
8989
this.captureQueryParameters = captureQueryParameters;
90-
internalNetworkExtractor =
91-
new InternalNetworkAttributesExtractor<>(
92-
getter, true, false);
90+
internalNetworkExtractor = new InternalNetworkAttributesExtractor<>(getter, true, false);
9391
serverAttributesExtractor = ServerAttributesExtractor.create(getter);
9492
}
9593

0 commit comments

Comments
 (0)