chore(build): Fix Go 1.25 build errors and support Go 1.24+ (#127)

* chore(build): Fix Go 1.25 build errors

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>

* chore: Fix linter issues

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>

---------

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Co-authored-by: Huxing Zhang <huxing.zhang@gmail.com>

Author: kakkoyun

.golangci.yml

@@ -323,7 +323,7 @@ linters:
     nolintlint:
       # Exclude following linters from requiring an explanation.
       # Default: []
-      allow-no-explanation: [ funlen, gocognit, golines ]
+      allow-no-explanation: [ funlen, gocognit, golines, exhaustive ]
       # Enable to require an explanation of nonzero length after each nolint directive.
       # Default: false
       require-explanation: true

go.mod

@@ -3,19 +3,19 @@
 
 module github.com/open-telemetry/opentelemetry-go-compile-instrumentation
 
-go 1.23.0
+go 1.24.0
 
 require (
 	github.com/dave/dst v0.27.3
 	github.com/stretchr/testify v1.11.1
 	github.com/urfave/cli/v3 v3.4.1
-	golang.org/x/mod v0.12.0
+	golang.org/x/mod v0.29.0
 	gopkg.in/yaml.v3 v3.0.1
 )
 
 require (
 	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
-	golang.org/x/sys v0.13.0 // indirect
-	golang.org/x/tools v0.13.0 // indirect
+	golang.org/x/sync v0.17.0 // indirect
+	golang.org/x/tools v0.38.0 // indirect
 )

go.sum

@@ -4,6 +4,8 @@ github.com/dave/jennifer v1.5.0 h1:HmgPN93bVDpkQyYbqhCHj5QlgvUkvEOzMyEvKLgCRrg=
 github.com/dave/jennifer v1.5.0/go.mod h1:4MnyiFIlZS3l5tSDn8VnzE6ffAhYBMB2SZntBsZGUok=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
+github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
+github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/sergi/go-diff v1.2.0 h1:XU+rvMAioB0UC3q1MFrIQy4Vo5/4VsRDQQXHsEya6xQ=
@@ -12,14 +14,12 @@ github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu
 github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
 github.com/urfave/cli/v3 v3.4.1 h1:1M9UOCy5bLmGnuu1yn3t3CB4rG79Rtoxuv1sPhnm6qM=
 github.com/urfave/cli/v3 v3.4.1/go.mod h1:FJSKtM/9AiiTOJL4fJ6TbMUkxBXn7GO9guZqoZtpYpo=
-golang.org/x/mod v0.12.0 h1:rmsUpXtvNzj340zd98LZ4KntptpfRHwpFOHG188oHXc=
-golang.org/x/mod v0.12.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
-golang.org/x/sync v0.3.0 h1:ftCYgMx6zT/asHUrPw8BLLscYtGznsLAnjq5RH9P66E=
-golang.org/x/sync v0.3.0/go.mod h1:FU7BRWz2tNW+3quACPkgCx/L+uEAv1htQ0V83Z9Rj+Y=
-golang.org/x/sys v0.13.0 h1:Af8nKPmuFypiUBjVoU9V20FiaFXOcuZI21p0ycVYYGE=
-golang.org/x/sys v0.13.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/tools v0.13.0 h1:Iey4qkscZuv0VvIt8E0neZjtPVQFSc870HQ448QgEmQ=
-golang.org/x/tools v0.13.0/go.mod h1:HvlwmtVNQAhOuCjW7xxvovg8wbNq7LwfXh/k7wXUl58=
+golang.org/x/mod v0.29.0 h1:HV8lRxZC4l2cr3Zq1LvtOsi/ThTgWnUk/y64QSs8GwA=
+golang.org/x/mod v0.29.0/go.mod h1:NyhrlYXJ2H4eJiRy/WDBO6HMqZQ6q9nk4JzS3NuCK+w=
+golang.org/x/sync v0.17.0 h1:l60nONMj9l5drqw6jlhIELNv9I0A4OFgRsG9k2oT9Ug=
+golang.org/x/sync v0.17.0/go.mod h1:9KTHXmSnoGruLpwFjVSX0lNNA75CykiMECbovNTZqGI=
+golang.org/x/tools v0.38.0 h1:Hx2Xv8hISq8Lm16jvBZ2VQf+RLmbd7wVUsALibYI/IQ=
+golang.org/x/tools v0.38.0/go.mod h1:yEsQ/d/YK8cjh0L6rZlY8tgtlKiBNTL14pGDJPJpYQs=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=

test/infra.go

@@ -4,6 +4,7 @@
 package test
 
 import (
+	"context"
 	"os/exec"
 	"path/filepath"
 	"testing"
@@ -18,10 +19,10 @@ import (
 // compiled binary program, and verify that the output of the binary program
 // is as expected.
 
-func runCmd(dir string, args ...string) (string, error) {
+func runCmd(ctx context.Context, dir string, args ...string) (string, error) {
 	path := args[0]
 	args = args[1:]
-	cmd := exec.Command(path, args...)
+	cmd := exec.CommandContext(ctx, path, args...)
 	cmd.Dir = dir
 	output, err := cmd.CombinedOutput()
 	if err != nil {
@@ -38,13 +39,13 @@ func BuildApp(t *testing.T, appDir string, args ...string) {
 	}
 	otelPath := filepath.Join("..", "..", binName)
 	args = append([]string{otelPath}, args...)
-	out, err := runCmd(appDir, args...)
+	out, err := runCmd(t.Context(), appDir, args...)
 	require.NoError(t, err, out)
 }
 
 // RunApp runs the application and returns the output.
 func RunApp(t *testing.T, dir string) string {
-	out, err := runCmd(dir, "./"+filepath.Base(dir))
+	out, err := runCmd(t.Context(), dir, "./"+filepath.Base(dir))
 	require.NoError(t, err, out)
 	return out
 }

tool/ex/error.go

@@ -128,7 +128,7 @@ func Wrapf(previousErr error, format string, args ...any) error {
 }
 
 func New(message string) error {
-	return wrapOrCreate(nil, message)
+	return wrapOrCreate(nil, "%s", message)
 }
 
 func Newf(format string, args ...any) error {

tool/internal/instrument/instrument_test.go

@@ -3,7 +3,6 @@
 package instrument
 
 import (
-	"context"
 	"encoding/json"
 	"fmt"
 	"log/slog"
@@ -48,7 +47,7 @@ func TestInstrument(t *testing.T) {
 	logger := slog.New(slog.NewTextHandler(os.Stdout, &slog.HandlerOptions{
 		Level: slog.LevelDebug,
 	}))
-	ctx := util.ContextWithLogger(context.Background(), logger)
+	ctx := util.ContextWithLogger(t.Context(), logger)
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			tempDir := setupTestEnvironment(t)

tool/internal/instrument/trampoline.go

@@ -105,7 +105,7 @@ func (ip *InstrumentPhase) materializeTemplate() error {
 		// Materialize variable declarations
 		if decl, ok := node.(*dst.GenDecl); ok {
 			// No further processing for variable declarations, just append them
-			//nolint:exhaustive // all possible tokens are handled
+			//nolint:exhaustive
 			switch decl.Tok {
 			case token.VAR:
 				ip.varDecls = append(ip.varDecls, decl)