fix: ci security issues fixed

Author: nipunaudemy

cmd/server/main.go

@@ -31,7 +31,11 @@ func main() {
 	if err != nil {
 		log.Fatalf("Failed to create database registry: %v", err)
 	}
-	defer registry.Close()
+	defer func() {
+		if err := registry.Close(); err != nil {
+			log.Printf("Error closing registry: %v", err)
+		}
+	}()
 
 	// Create database manager
 	manager := db.NewManager(registry)
@@ -49,7 +53,9 @@ func main() {
 			if closeErr := manager.CloseAll(); closeErr != nil {
 				log.Printf("Error closing connections: %v", closeErr)
 			}
-			registry.Close()
+			if closeErr := registry.Close(); closeErr != nil {
+				log.Printf("Error closing registry: %v", closeErr)
+			}
 			log.Fatalf("Failed to resolve default database path: %v", err)
 		}
 

internal/db/batch_test.go

@@ -25,7 +25,11 @@ func TestBatchOperations(t *testing.T) {
 	if err != nil {
 		t.Fatalf("Failed to create registry: %v", err)
 	}
-	defer registry.Close()
+	defer func() {
+		if err := registry.Close(); err != nil {
+			t.Logf("Error closing registry: %v", err)
+		}
+	}()
 
 	// Register test database
 	err = registry.RegisterDatabase(&DatabaseInfo{

internal/mcp/resources/db_resources_test.go

@@ -65,8 +65,12 @@ func setupTestDB(t *testing.T) (*db.Manager, func()) {
 	}
 
 	cleanup := func() {
-		manager.CloseAll()
-		registry.Close()
+		if err := manager.CloseAll(); err != nil {
+			t.Logf("Error closing manager: %v", err)
+		}
+		if err := registry.Close(); err != nil {
+			t.Logf("Error closing registry: %v", err)
+		}
 	}
 
 	return manager, cleanup

internal/mcp/server_test.go

@@ -57,8 +57,12 @@ func setupTestManager(t *testing.T) (*db.Manager, func()) {
 	}
 
 	cleanup := func() {
-		manager.CloseAll()
-		registry.Close()
+		if err := manager.CloseAll(); err != nil {
+			t.Logf("Error closing manager: %v", err)
+		}
+		if err := registry.Close(); err != nil {
+			t.Logf("Error closing registry: %v", err)
+		}
 		os.Remove(testDBPath) // Clean up temp file
 	}
 

internal/mcp/tools/db_tools_test.go

@@ -65,8 +65,12 @@ func setupTestDB(t *testing.T) (*db.Manager, func()) {
 	}
 
 	cleanup := func() {
-		manager.CloseAll()
-		registry.Close()
+		if err := manager.CloseAll(); err != nil {
+			t.Logf("Error closing manager: %v", err)
+		}
+		if err := registry.Close(); err != nil {
+			t.Logf("Error closing registry: %v", err)
+		}
 		// Clean up test file
 		os.Remove(testDBPath) // Remove the test file (ignore errors)
 	}