Always call mpm install even if MATLAB is in toolcache

Author: mcafaro

src/install.ts

@@ -38,15 +38,15 @@ export async function install(platform: string, architecture: string, release: s
             matlabArch = "x64";
         }
 
-        let [destination, alreadyExists]: [string, boolean] = await matlab.getToolcacheDir(platform, releaseInfo);
+        let [destination]: [string, boolean] = await matlab.getToolcacheDir(platform, releaseInfo);
         let cacheHit = false;
 
         if (useCache) {
             const supportFilesDir = matlab.getSupportPackagesPath(platform, releaseInfo.name);
             cacheHit = await cache.restoreMATLAB(releaseInfo, platform, matlabArch, products, destination, supportFilesDir);
         }
 
-        if (!alreadyExists && !cacheHit) {
+        if (!cacheHit) {
             const mpmPath: string = await mpm.setup(platform, matlabArch);
             await mpm.install(mpmPath, releaseInfo, products, destination);
             core.saveState(State.InstallSuccessful, 'true');

src/install.unit.test.ts

@@ -79,11 +79,11 @@ describe("install procedure", () => {
         expect(setOutputMock).toHaveBeenCalledTimes(1);
     });
 
-    it("NoOp on existing install", async () => {
+    it("re-calls MPM install even if MATLAB already exists in toolcache", async () => {
         matlabGetToolcacheDirMock.mockResolvedValue(["/opt/hostedtoolcache/MATLAB/9.13.0/x64", true]);
         await expect(doInstall()).resolves.toBeUndefined();
-        expect(mpmInstallMock).toHaveBeenCalledTimes(0);
-        expect(saveStateMock).toHaveBeenCalledTimes(0);
+        expect(mpmInstallMock).toHaveBeenCalledTimes(1);
+        expect(saveStateMock).toHaveBeenCalledTimes(1);
         expect(addPathMock).toHaveBeenCalledTimes(1);
         expect(setOutputMock).toHaveBeenCalledTimes(1);
     });