From 01010efca03fc1e81b8cef44aafd6f9db9dfab6c Mon Sep 17 00:00:00 2001 From: "Davide P. Cervone" Date: Sun, 19 Oct 2025 15:06:01 -0400 Subject: [PATCH 1/3] Moe press() call from mousedown to mouseup. --- ts/item_command.ts | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/ts/item_command.ts b/ts/item_command.ts index ab1804b..f6b212d 100644 --- a/ts/item_command.ts +++ b/ts/item_command.ts @@ -10,7 +10,7 @@ * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either expressor implied. * See the License for the specific language governing permissions and * limitations under the License. */ @@ -66,6 +66,24 @@ export class Command extends AbstractItem { super(menu, 'command', content, id); } + /** + * @param {MouseEvent} event The mousedown event + */ + public mousedown(event: MouseEvent) { + this.stop(event); + } + + /** + * Do the press on mouseup so menu gets the mouse up rather than a dialog box + * after the menu closes. + * + * @param {MouseEvent} event The mouseup event + */ + public mouseup(event: MouseEvent) { + this.press(); + this.stop(event); + } + /** * @override */ From 78061411f9e30ffb2ef01d74e4489ab4b74151a1 Mon Sep 17 00:00:00 2001 From: "Davide P. Cervone" Date: Thu, 13 Nov 2025 07:03:53 -0500 Subject: [PATCH 2/3] Update ts/item_command.ts Co-authored-by: Volker Sorge --- ts/item_command.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts/item_command.ts b/ts/item_command.ts index f6b212d..75db867 100644 --- a/ts/item_command.ts +++ b/ts/item_command.ts @@ -10,7 +10,7 @@ * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either expressor implied. + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ From 7e0c38d11bd532fcc93fc0771d0087997c646477 Mon Sep 17 00:00:00 2001 From: "Davide P. Cervone" Date: Thu, 13 Nov 2025 07:04:00 -0500 Subject: [PATCH 3/3] Update ts/item_command.ts Co-authored-by: Volker Sorge --- ts/item_command.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts/item_command.ts b/ts/item_command.ts index 75db867..005809c 100644 --- a/ts/item_command.ts +++ b/ts/item_command.ts @@ -74,7 +74,7 @@ export class Command extends AbstractItem { } /** - * Do the press on mouseup so menu gets the mouse up rather than a dialog box + * Perform press on mouseup so menu gets the mouse up rather than a dialog box * after the menu closes. * * @param {MouseEvent} event The mouseup event