Code Refactoring

Author: srenon

Block/Adminhtml/System/Config/Form/Field/MiscScript.php

@@ -87,7 +87,7 @@ public function getTemplateButtonList()
 
         foreach ($this->helper->getTemplateVariableKey() as $key) {
             $html .= sprintf(
-                '<%s style="%s" data-mage-init=\\\'%s\\\' type="button"> %s </button>',
+                '<%s style="%s" data-mage-init=\\\'%s\\\' type="button">%s</button>',
                 'button',
                 'margin:3px;',
                 '{"checkoutSuccessMiscScript":{"textareaId":"<%- _id %>_scripts"}}',

README.md

@@ -7,8 +7,6 @@
 [![GitHub stars](https://img.shields.io/github/stars/magepal/magento2-checkout-success-misc-script.svg)](https://www.magepal.com/order-confirmation-miscellaneous-scripts-for-magento-2.html)
 [![GitHub forks](https://img.shields.io/github/forks/magepal/magento2-checkout-success-misc-script.svg)](https://www.magepal.com/order-confirmation-miscellaneous-scripts-for-magento-2.html)
 
-
-
 <a href="https://www.magepal.com/order-confirmation-miscellaneous-scripts-for-magento-2.html" ><img alt="Magento2 - Edit Order Email" src="https://user-images.githubusercontent.com/1415141/108899005-e717f680-75e5-11eb-9df8-719925e05baa.png" /></a>
 
 Add miscellaneous HTML and scripts quickly and easily to your Magento2 checkout success page. Ideal for testing new page styling of your order confirmation page, adding new static blocks or other customization to your checkout page.

composer.json

@@ -16,13 +16,13 @@
         "php": "~5.6.0|7.0.2|7.0.4|~7.0.6|~7.1.0|~7.1.3|~7.2.0|~7.3.0|~7.4.0",
         "magento/module-backend": "100.0.*|100.1.*|100.2.*|101.0.*|102.0.*",
         "magento/framework": "100.0.*|100.1.*|101.0.*|102.0.*|103.0.*",
-        "magepal/magento2-core":">1.1.0"
+        "magepal/magento2-core": ">=1.1.0"
     },
     "suggest": {
         "magepal/magento2-preview-checkout-success-page":"Preview checkout success page from admin"
     },
     "type": "magento2-module",
-    "version": "1.2.0",
+    "version": "1.2.1",
     "license": [
         "proprietary"
     ],

etc/adminhtml/system.xml

@@ -20,8 +20,8 @@
                 <attribute type="expanded">1</attribute>
                 <comment>
                     <![CDATA[
-                    <div id="magepal-info-csms">
-                        Copyright © 2020 <a href="https://www.magepal.com/magento2/extensions.html?utm_source=miscellaneous-scripts&utm_medium=admin" target="_blank">MagePal, LLC</a>
+                    <div class="magepal-info">
+                        Copyright © 2021 <a href="https://www.magepal.com/magento2/extensions.html?utm_source=miscellaneous-scripts&utm_medium=admin" target="_blank">MagePal, LLC</a>
                         <a href="https://www.magepal.com/help/docs/success-page-miscellaneous-scripts-magento-2/?utm_source=miscellaneous-scripts&utm_medium=admin#documentation" target="_blank">Documentation</a>
                         <a href="https://www.magepal.com/help/docs/success-page-miscellaneous-scripts-magento-2/?utm_source=miscellaneous-scripts&utm_medium=admin#support">Support</a>
                         <a href="https://www.magepal.com/help/docs/success-page-miscellaneous-scripts-magento-2?utm_source=miscellaneous-scripts&utm_medium=admin#current_version" target="_blank">Latest Version</a>
@@ -31,34 +31,10 @@
                     <div>
                     Design beautiful order confirmation page with our new <a href="https://www.magepal.com/enhanced-success-page.html">Enhanced Success Page</a> extension.
                     </div>
-                    <hr style="border-top: 1px solid #e3e3e3" />
-                    <style>
-                        #magepal-info-csms a {
-                            font-weight: bold;
-                            border-left: 2px solid #e3e3e3;
-                            padding-left:10px;
-                            padding-right:10px;
-                            color: #ef7e1e;
-                        }
-
-                        #magepal-info-csms a:first-child {
-                            padding-left: 5px;
-                            border-left: none;
-                        }
-
-                        #magepal-info-csms {
-                            padding-bottom: 5px;
-                        }
-                        .section-config.active #magepal_checkout_preview_success_page-head {
-                            padding-bottom: 0px;
-                        }
-                     </style>]]>
+                    <hr class="magepal-hr" />
+                    ]]>
                 </comment>
-                <field id="module_version" translate="label" type="label" sortOrder="0" showInDefault="1" showInWebsite="0" showInStore="0">
-                    <label>Module Version</label>
-                    <frontend_model>MagePal\CheckoutSuccessMiscScript\Block\Adminhtml\System\Config\Form\Module\Version</frontend_model>
-                </field>
-                <field id="composer_version" translate="label" type="label" sortOrder="1" showInDefault="1" showInWebsite="0" showInStore="0">
+                <field id="MagePal_CheckoutSuccessMiscScript" translate="label" type="label" sortOrder="1" showInDefault="1" showInWebsite="0" showInStore="0">
                     <label>Composer Version</label>
                     <frontend_model>MagePal\CheckoutSuccessMiscScript\Block\Adminhtml\System\Config\Form\Composer\Version</frontend_model>
                 </field>
@@ -70,7 +46,6 @@
                     <label>HTML and Scripts</label>
                     <frontend_model>MagePal\CheckoutSuccessMiscScript\Block\Adminhtml\System\Config\Form\Field\MiscScript</frontend_model>
                     <backend_model>MagePal\CheckoutSuccessMiscScript\Model\Config\Backend\Serialized\MiscScriptArraySerialized</backend_model>
-                    <comment></comment>
                     <depends>
                         <field id="*/*/active">1</field>
                     </depends>