test: Migrate from g5 to g6 instances, fix test failures caused by invalid labels (#367)

* move test upload logic to git submodule, and use it in e2e workflow

* update script folder name

* migrate g5 to g6 and fix label too long error in tests

* remove test script folder

Author: ykim-akamai

test/fixtures/linode_instances.json

@@ -8,7 +8,7 @@
       "hypervisor": "kvm",
       "id": 123,
       "status": "running",
-      "type": "g5-standard-1",
+      "type": "g6-standard-1",
       "alerts": {
         "network_in": 5,
         "network_out": 5,

test/fixtures/linode_types.json

@@ -31,7 +31,7 @@
       "network_out": 1000,
       "vcpus": 1,
       "gpus": 0,
-      "id": "g5-nanode-1",
+      "id": "g6-nanode-1",
       "label": "Linode 1024",
       "price": {
         "hourly": 0.0075,
@@ -127,7 +127,7 @@
       "network_out": 1000,
       "vcpus": 1,
       "gpus": 0,
-      "id": "g5-standard-1",
+      "id": "g6-standard-1",
       "label": "Linode 2048",
       "price": {
         "hourly": 0.015,
@@ -175,7 +175,7 @@
       "network_out": 1000,
       "vcpus": 2,
       "gpus": 1,
-      "id": "g5-gpu-2",
+      "id": "g6-gpu-2",
       "label": "Linode 4096",
       "price": {
         "hourly": 0.03,

test/fixtures/tags_something.json

@@ -10,7 +10,7 @@
         "hypervisor": "kvm",
         "id": 123,
         "status": "running",
-        "type": "g5-standard-1",
+        "type": "g6-standard-1",
         "alerts": {
           "network_in": 5,
           "network_out": 5,

test/integration/conftest.py

@@ -308,7 +308,7 @@ def create_vpc_with_subnet_and_linode(
     label = "TestSDK-" + timestamp
 
     instance, password = test_linode_client.linode.instance_create(
-        "g5-standard-4", vpc.region, image="linode/debian11", label=label
+        "g6-standard-1", vpc.region, image="linode/debian11", label=label
     )
 
     yield vpc, subnet, instance, password

test/integration/helpers.py

@@ -7,14 +7,14 @@
 
 
 def get_test_label():
-    unique_timestamp = str(time.time_ns())
-    label = "IntTestSDK_" + unique_timestamp
+    unique_timestamp = str(time.time_ns())[:-3]
+    label = "test_" + unique_timestamp
     return label
 
 
 def get_rand_nanosec_test_label():
-    unique_timestamp = str(time.time_ns())
-    label = "IntTestSDK_" + unique_timestamp
+    unique_timestamp = str(time.time_ns())[:-3]
+    label = "test_" + unique_timestamp
     return label
 
 

test/integration/linode_client/test_linode_client.py

@@ -276,7 +276,7 @@ def test_cluster_create_with_api_objects(test_linode_client):
     version = client.lke.versions()[0]
     region = client.regions().first()
     node_pools = client.lke.node_pool(node_type, 3)
-    label = get_test_label() + "-cluster"
+    label = get_test_label()
 
     cluster = client.lke.cluster_create(region, label, node_pools, version)
 

test/integration/models/test_linode.py

@@ -349,7 +349,7 @@ def test_linode_firewalls(linode_with_volume_firewall):
     firewalls = linode.firewalls()
 
     assert len(firewalls) > 0
-    assert "TestSDK" in firewalls[0].label
+    assert "test" in firewalls[0].label
 
 
 def test_linode_volumes(linode_with_volume_firewall):
@@ -358,7 +358,7 @@ def test_linode_volumes(linode_with_volume_firewall):
     volumes = linode.volumes()
 
     assert len(volumes) > 0
-    assert "TestSDK" in volumes[0].label
+    assert "test" in volumes[0].label
 
 
 def wait_for_disk_status(disk: Disk, timeout):

test/unit/linode_client_test.py

@@ -559,7 +559,7 @@ def test_instance_create(self):
         """
         with self.mock_post("linode/instances/123") as m:
             l = self.client.linode.instance_create(
-                "g5-standard-1", "us-east-1a"
+                "g6-standard-1", "us-east-1a"
             )
 
             self.assertIsNotNone(l)
@@ -568,7 +568,7 @@ def test_instance_create(self):
             self.assertEqual(m.call_url, "/linode/instances")
 
             self.assertEqual(
-                m.call_data, {"region": "us-east-1a", "type": "g5-standard-1"}
+                m.call_data, {"region": "us-east-1a", "type": "g6-standard-1"}
             )
 
     def test_instance_create_with_image(self):
@@ -577,7 +577,7 @@ def test_instance_create_with_image(self):
         """
         with self.mock_post("linode/instances/123") as m:
             l, pw = self.client.linode.instance_create(
-                "g5-standard-1", "us-east-1a", image="linode/debian9"
+                "g6-standard-1", "us-east-1a", image="linode/debian9"
             )
 
             self.assertIsNotNone(l)
@@ -589,7 +589,7 @@ def test_instance_create_with_image(self):
                 m.call_data,
                 {
                     "region": "us-east-1a",
-                    "type": "g5-standard-1",
+                    "type": "g6-standard-1",
                     "image": "linode/debian9",
                     "root_pass": pw,
                 },
@@ -708,7 +708,7 @@ def test_cluster_create_with_api_objects(self):
             )
             self.assertEqual(m.call_data["region"], "ap-west")
             self.assertEqual(
-                m.call_data["node_pools"], [{"type": "g5-nanode-1", "count": 3}]
+                m.call_data["node_pools"], [{"type": "g6-nanode-1", "count": 3}]
             )
             self.assertEqual(m.call_data["k8s_version"], "1.19")
 

test/unit/objects/linode_test.py

@@ -560,7 +560,7 @@ def test_get_type_by_id(self):
         """
         Tests that a Linode type is loaded correctly by ID
         """
-        t = Type(self.client, "g5-nanode-1")
+        t = Type(self.client, "g6-nanode-1")
         self.assertEqual(t._populated, False)
 
         self.assertEqual(t.vcpus, 1)
@@ -574,7 +574,7 @@ def test_get_type_gpu(self):
         """
         Tests that gpu types load up right
         """
-        t = Type(self.client, "g5-gpu-2")
+        t = Type(self.client, "g6-gpu-2")
         self.assertEqual(t._populated, False)
 
         self.assertEqual(t.gpus, 1)