fix some minor issues

Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>

Author: ryanzhang-oss

pkg/propertyprovider/azure/controllers/node.go

@@ -26,9 +26,7 @@ import (
 	"k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/klog/v2"
 	ctrl "sigs.k8s.io/controller-runtime"
-	"sigs.k8s.io/controller-runtime/pkg/builder"
 	"sigs.k8s.io/controller-runtime/pkg/client"
-	"sigs.k8s.io/controller-runtime/pkg/predicate"
 
 	"github.com/kubefleet-dev/kubefleet/pkg/propertyprovider/azure/trackers"
 )
@@ -95,6 +93,6 @@ func (r *NodeReconciler) SetupWithManager(mgr ctrl.Manager, controllerName strin
 	// Reconcile any node changes (create, update, delete).
 	return ctrl.NewControllerManagedBy(mgr).
 		Named(controllerName).
-		For(&corev1.Node{}, builder.WithPredicates(predicate.GenerationChangedPredicate{})).
+		For(&corev1.Node{}).
 		Complete(r)
 }

pkg/propertyprovider/azure/provider.go

@@ -473,16 +473,13 @@ func (p *PropertyProvider) collectK8sVersion(_ context.Context, properties map[c
 	// Check if we have a cached version that is still valid.
 	p.k8sVersionMutex.RLock()
 	if p.cachedK8sVersion != "" && now.Sub(p.cachedK8sVersionObservedTime) < k8sVersionCacheTTL {
+		defer p.k8sVersionMutex.RUnlock()
 		// Cache is still valid, use the cached version.
-		cachedVersion := p.cachedK8sVersion
-		cacheTime := p.cachedK8sVersionObservedTime
-		p.k8sVersionMutex.RUnlock()
-
 		properties[propertyprovider.K8sVersionProperty] = clusterv1beta1.PropertyValue{
-			Value:           cachedVersion,
-			ObservationTime: metav1.NewTime(cacheTime),
+			Value:           p.cachedK8sVersion,
+			ObservationTime: metav1.NewTime(p.cachedK8sVersionObservedTime),
 		}
-		klog.V(2).InfoS("Using cached Kubernetes version", "version", cachedVersion, "cacheAge", now.Sub(cacheTime))
+		klog.V(2).InfoS("Using cached Kubernetes version", "version", p.cachedK8sVersion, "cacheAge", now.Sub(p.cachedK8sVersionObservedTime))
 		return
 	}
 	p.k8sVersionMutex.RUnlock()