Inconsistent labels across resources

[sebastiangaiser]

Describe the bug:
All "components" use different labels for resources. Examples:

Operator:

app.kubernetes.io/instance: logging-operator
app.kubernetes.io/name: logging-operator

Fluent-Bit:

app.kubernetes.io/instance: logging-operator
app.kubernetes.io/name: fluentbit

FluentD:

app.kubernetes.io/component: fluentd
app.kubernetes.io/name: fluentd

Host Tailer:

app.kubernetes.io/instance: <my-host-tailer-name>-host-tailer
app.kubernetes.io/name: host-tailer

Expected behaviour:
All "components" should use a consistent labeling

Environment details:

• logging-operator version (e.g. 2.1.1): 6.0.3

[csatib02]

Hey @sebastiangaiser.

What labeling suggestions do you have/would like to see?

[sebastiangaiser]

Hey, my suggestion would be using them in the same way as Helm does it:

app.kubernetes.io/name: {{ include "logging-operator.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}

Taken from https://github.com/kube-logging/logging-operator/blob/c351e114b45292b56dda217e74130c1f33932666/charts/logging-operator/templates/_helpers.tpl#L58C1-L60C48

In addition I would add the app.kubernetes.io/component label like for FluentD already:

app.kubernetes.io/component: fluentd

I think this aligns with https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels

[csatib02]

Sounds good, are you planning to work on this?

[sebastiangaiser]

Sorry, I probably won't have the time for it