extract a method

Author: gavinking

hibernate-core/src/main/java/org/hibernate/boot/model/internal/AnnotatedJoinColumns.java

@@ -426,7 +426,7 @@ private Identifier columnIdentifier(
 			ImplicitNamingStrategy implicitNamingStrategy,
 			InFlightMetadataCollector collector,
 			Database database) {
-		boolean isRefColumnQuoted = isQuoted( logicalReferencedColumn );
+		final boolean isRefColumnQuoted = isQuoted( logicalReferencedColumn );
 
 		if ( isMappedBySide() ) {
 			// NOTE: An @ElementCollection can't be mappedBy, but the client code
@@ -439,17 +439,10 @@ private Identifier columnIdentifier(
 		}
 		else if ( isOwnerSide() ) {
 			final String logicalTableName = collector.getLogicalTableName( referencedEntity.getTable() );
-			Identifier columnIdentifier = implicitNamingStrategy.determineJoinColumnName(
-					new OwnedImplicitJoinColumnNameSource(referencedEntity, logicalTableName, logicalReferencedColumn)
+			final Identifier columnIdentifier = implicitNamingStrategy.determineJoinColumnName(
+					new OwnedImplicitJoinColumnNameSource( referencedEntity, logicalTableName, logicalReferencedColumn )
 			);
-			// HHH-11826 magic. See AnnotatedColumn and the HHH-6005 comments
-			if ( columnIdentifier.getText().contains( "_{element}_" ) ) {
-				columnIdentifier = Identifier.toIdentifier(
-						columnIdentifier.getText().replace( "_{element}_", "_" ),
-						columnIdentifier.isQuoted()
-				);
-			}
-			return quoteIfNecessary( isRefColumnQuoted, logicalTableName, columnIdentifier );
+			return quoteIfNecessary( isRefColumnQuoted, logicalTableName, handleElement( columnIdentifier ) );
 		}
 		else {
 			final Identifier logicalTableName = database.toIdentifier(
@@ -478,9 +471,23 @@ public Identifier getReferencedPrimaryKeyColumnName() {
 		}
 	}
 
+	private Identifier handleElement(Identifier columnIdentifier) {
+		// HHH-11826 magic. See AnnotatedColumn and the HHH-6005 comments
+		if ( columnIdentifier.getText().contains( "_{element}_" ) ) {
+			return Identifier.toIdentifier(
+					columnIdentifier.getText().replace( "_{element}_", "_" ),
+					columnIdentifier.isQuoted()
+			);
+		}
+		else {
+			return columnIdentifier;
+		}
+	}
+
 	private static Identifier quoteIfNecessary(
 			boolean isRefColumnQuoted, Identifier logicalTableName, Identifier columnIdentifier) {
-		return !columnIdentifier.isQuoted() && ( isRefColumnQuoted || logicalTableName.isQuoted() )
+		return !columnIdentifier.isQuoted()
+			&& ( isRefColumnQuoted || logicalTableName.isQuoted() )
 				? Identifier.quote( columnIdentifier )
 				: columnIdentifier;
 	}
@@ -591,8 +598,9 @@ public Identifier getReferencedColumnName() {
 				return null;
 			}
 
-			final Property mappedByProperty = collector.getEntityBinding( getMappedByEntityName() )
-					.getProperty( getMappedByPropertyName() );
+			final Property mappedByProperty =
+					collector.getEntityBinding( getMappedByEntityName() )
+							.getProperty( getMappedByPropertyName() );
 			final SimpleValue value = (SimpleValue) mappedByProperty.getValue();
 			if ( value.getSelectables().isEmpty() ) {
 				throw new AnnotationException(