Fix copilot implementation

Author: hvitved

rust/ql/.generated.list

@@ -0,0 +1,7 @@
+/**
+ * This module provides the public class `ConstAccess`.
+ */
+
+private import internal.ConstImpl
+
+final class ConstAccess = Impl::ConstAccess;

rust/ql/.gitattributes

@@ -1,20 +1,19 @@
-// generated by codegen, remove this comment if you wish to edit this file
 /**
  * This module provides a hand-modifiable wrapper around the generated class `Const`.
  *
  * INTERNAL: Do not use.
  */
 
 private import codeql.rust.elements.internal.generated.Const
-private import codeql.rust.elements.PathExpr
-private import codeql.rust.elements.internal.PathExprBaseImpl::Impl as PathExprBaseImpl
+private import codeql.rust.elements.internal.PathExprImpl::Impl as PathExprImpl
 private import codeql.rust.internal.PathResolution
 
 /**
  * INTERNAL: This module contains the customizable definition of `Const` and should not
  * be referenced directly.
  */
 module Impl {
+  // the following QLdoc is generated: if you need to edit it, do it in the schema file
   /**
    * A constant item declaration.
    *
@@ -37,21 +36,14 @@ module Impl {
    * }
    * ```
    */
-  class ConstAccess extends PathExprBaseImpl::PathExprBase {
+  class ConstAccess extends PathExprImpl::PathExpr {
     private Const c;
 
-    ConstAccess() {
-      exists(PathExpr pe |
-        pe = this and
-        c = resolvePath(pe.getPath())
-      )
-    }
+    ConstAccess() { c = resolvePath(this.getPath()) }
 
     /** Gets the constant being accessed. */
     Const getConst() { result = c }
 
-    override string toStringImpl() { result = c.getName().getText() }
-
     override string getAPrimaryQlClass() { result = "ConstAccess" }
   }
 }

rust/ql/lib/codeql/rust/elements/Const.qll

@@ -9,6 +9,7 @@ import codeql.rust.elements.ArithmeticOperation
 import codeql.rust.elements.AssignmentOperation
 import codeql.rust.elements.BitwiseOperation
 import codeql.rust.elements.ComparisonOperation
+import codeql.rust.elements.ConstAccess
 import codeql.rust.elements.DerefExpr
 import codeql.rust.elements.LiteralExprExt
 import codeql.rust.elements.LogicalOperation

rust/ql/lib/codeql/rust/elements/ConstAccess.qll

@@ -0,0 +1,8 @@
+testFailures
+constAccess
+| main.rs:17:13:17:24 | GLOBAL_CONST | main.rs:1:1:1:29 | Const |
+| main.rs:19:13:19:24 | STRING_CONST | main.rs:2:1:2:35 | Const |
+| main.rs:21:13:21:33 | ...::ASSOC_CONST | main.rs:9:5:9:33 | Const |
+| main.rs:23:13:23:35 | ...::MODULE_CONST | main.rs:13:5:13:38 | Const |
+| main.rs:25:8:25:19 | GLOBAL_CONST | main.rs:1:1:1:29 | Const |
+| main.rs:29:16:29:36 | ...::ASSOC_CONST | main.rs:9:5:9:33 | Const |

rust/ql/lib/codeql/rust/elements/internal/ConstImpl.qll

@@ -14,27 +14,19 @@ mod my_module {
 }
 
 fn use_consts() {
-    // $ const_access=GLOBAL_CONST
-    let x = GLOBAL_CONST;
-    // $ const_access=GLOBAL_CONST
-    println!("{}", GLOBAL_CONST);
+    let x = GLOBAL_CONST; // $ const_access=GLOBAL_CONST
 
-    // $ const_access=STRING_CONST
-    let s = STRING_CONST;
+    let s = STRING_CONST; // $ const_access=STRING_CONST
 
-    // $ const_access=ASSOC_CONST
-    let y = MyStruct::ASSOC_CONST;
+    let y = MyStruct::ASSOC_CONST; // $ const_access=ASSOC_CONST
 
-    // $ const_access=MODULE_CONST
-    let z = my_module::MODULE_CONST;
+    let z = my_module::MODULE_CONST; // $ const_access=MODULE_CONST
 
-    // $ const_access=GLOBAL_CONST
-    if GLOBAL_CONST > 0 {
+    if GLOBAL_CONST > 0 { // $ const_access=GLOBAL_CONST
         println!("positive");
     }
 
-    // $ const_access=ASSOC_CONST
-    let arr = [MyStruct::ASSOC_CONST; 5];
+    let arr = [MyStruct::ASSOC_CONST; 5]; // $ const_access=ASSOC_CONST
 }
 
 fn main() {