OpenSSL Version issues

[SebTV]

Quick question:
https://github.com/git-for-windows/git/releases says

[Git for Windows v2.51.1.windows.1](https://github.com/git-for-windows/git/releases/tag/v2.51.1.windows.1)
[...]
New Features
[...]
    Comes with [OpenSSL v3.5.4](https://www.openssl.org/news/openssl-3.5-notes.html).

But subprojects/openssl.wrap refers to OpenSSL 3.0.8.
Is this really OpenSSL 3.5.4?

[dscho]

subprojects/ was introduced in 904339e, to support building with Meson. I am an anti-fan of the idea of building all dependencies from scratch, every single time, in CI, and recommended against that approach. One problem that you buy into when you do that is to open yourself up for network problems or compile problems whose resolution is outside of your power (or for that matter, responsibility). Another problem is that you now have another place where you need to update dependency versions.

In any case, this is not a part of Git's source code that is maintained by the Git for Windows project (heck, I never wanted to replace CMake with Meson, but that's what I'll end up being forced to!), so please report this to the Git mailing list (send plain-text messages, HTML messages are dropped silently).

[SebTV]

But what is the preferred way to build on Windows, if meson picks the wrong files?

[rimrul]

But what is the preferred way to build on Windows,

That entirely depends on what you want to do.

if meson picks the wrong files?

They're not wrong, per se, just not the versions of various dependencies you'd get with Git for Windows. (And in the case of openssl 3.0.8 missing about 2 years of security updates)

What we do is build using the makefile, with various dependencies provided by the Git for Windows SDK.

You can also build through cmake, which AFAIK is a convenient way to build if you want to use Visual Studio.

[dscho]

what is the preferred way to build on Windows

See https://gitforwindows.org/building-git.