Skip to content

fix: alarm configuration showing up in every change set #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix: alarm configuration showing up in every change set #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a71f967
Fix alarm configuration showing up in every change set
Ic3w0lf Feb 4, 2025
a08619d
terraform-docs: automated action
github-actions[bot] Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ preconfigured solution for seamless scalability and high availability."

## Resources

- resource.aws_cloudwatch_log_group.main (main.tf#310)
- resource.aws_cloudwatch_log_group.main (main.tf#313)
- resource.aws_codedeploy_app.main (main.tf#231)
- resource.aws_codedeploy_deployment_group.main (main.tf#238)
- resource.aws_ecs_service.main (main.tf#56)
Expand Down
11 changes: 7 additions & 4 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,10 +268,13 @@ resource "aws_codedeploy_deployment_group" "main" {
events = var.codedeploy_auto_rollback_events
}

alarm_configuration {
enabled = length(var.codedeploy_cloudwatch_alarm_names) > 0 ? true : false
alarms = var.codedeploy_cloudwatch_alarm_names
ignore_poll_alarm_failure = var.codedeploy_ignore_poll_alarm_failure
dynamic "alarm_configuration" {
for_each = length(var.codedeploy_cloudwatch_alarm_names) > 0 ? [true] : []

content {
alarms = var.codedeploy_cloudwatch_alarm_names
ignore_poll_alarm_failure = var.codedeploy_ignore_poll_alarm_failure
}
}

load_balancer_info {
Expand Down