Feat/deprecated local ads db migration #91
Conversation
- Update core from v1.3.1 to e7c808c - Update dart_frog from 1.2.4 to 1.2.5 - Update analyzer from 8.4.0 to 8.4.1 - Override core dependency to use specific git ref
- Remove unused localAdRepository from AppDependencies - Delete DataMongodb initialization for LocalAd
- Remove the provider for DataRepository<LocalAd> in the middleware - This change simplifies the middleware setup by removing an unused repository
…ation log - Remove all references to 'local_ad' in DataOperationRegistry - Add initialization log message for DataOperationRegistry - Reorganize log and registry initialization order
- Removed the 'local_ad' model configuration from the model registry - This change affects the ModelConfig map in model_registry.dart
- Remove local ads seeding process from database initialization - Delete local_ads collection indexing by adType - Set AdPlatformType.admob as the default primaryAdPlatform
- Add migration to delete 'local' ad platform from remote configs collection - Remove 'local' key from adConfig.platformAdIdentifiers map - Update primaryAdPlatform from 'local' to 'admob' where applicable - Prevent deserialization errors after removing AdPlatformType.local
- Removed the initial comment section in the PR template - This change simplifies the template and focuses on the actual content
Summary of ChangesHello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically removes the deprecated 'local ads' feature from the application. It ensures a clean transition by introducing a database migration to update existing configurations, eliminating all code related to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively removes the deprecated local_ad feature. The changes are comprehensive, touching dependency injection, data registries, database seeding, and middleware. A new database migration is included to clean up related data from the remote_configs collection, which is a great practice. The migration itself is well-documented and its logic is sound. My only suggestion relates to the use of dependency_overrides in pubspec.yaml, which should be treated as a temporary measure to avoid long-term maintenance issues.
- Remove unnecessary comments about ownership checks - Clarify that User may be null if not authenticated - Simplify description of the final data operation - Fix typo: "inner-most" should be "innermost"
github-project-automation
bot
moved this from Backlog
to Done
in Flutter News App Project
Status
READY
Description
This pull request systematically removes the deprecated 'local ads' feature from the application. It ensures a clean transition by introducing a database migration to update existing configurations, eliminating all code related to LocalAd data handling, and updating dependencies. The changes span across dependency injection, data registries, model definitions, and initial database setup, ensuring the 'local ads' concept is fully purged from the codebase and database.
Type of Change