Skip to content

Conversation

@DanielLeviLucas
Copy link

@DanielLeviLucas DanielLeviLucas commented Nov 11, 2025

This PR fixes a mistake in docstring and deprecation message of AsyncSession.execute() (we should await execute method and only then call scalars):

heroes = await session.execute(select(Hero)).scalars().all()

@DanielLeviLucas DanielLeviLucas changed the title Fix async example in session.execute() docstring & deprecation message 🐛 Fix async example in session.execute() docstring & deprecation message Nov 11, 2025
@DanielLeviLucas DanielLeviLucas changed the title 🐛 Fix async example in session.execute() docstring & deprecation message 📝 Fix async example in session.execute() docstring & deprecation message Nov 11, 2025
@YuriiMotov YuriiMotov added the bug Something isn't working label Nov 11, 2025
Copy link
Member

@YuriiMotov YuriiMotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DanielLeviLucas, thanks!

@YuriiMotov YuriiMotov added docs Improvements or additions to documentation and removed bug Something isn't working labels Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants