feat: Fragment identifier full line ignore #2626
Open
+79
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jacobsorme is attempting to deploy a commit to the Docsify Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sy-records
changed the title
sy-records
requested review from
a team,
Copilot,
paulhibbitts and
sy-records
Copilot finished reviewing on behalf of
sy-records
November 11, 2025 02:39
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new :fragmentFullLine option that enables full-line exclusion of fragment identifier lines when embedding file fragments. When enabled, the entire line containing the fragment marker (e.g., /// [demo] comment text) is excluded from the embedded content, not just the marker itself.
Key Changes:
- Added
fragmentFullLineparameter toextractFragmentContentfunction and updated regex logic to support full-line matching - Updated compiler to pass through
fragmentFullLineconfiguration - Fixed grammar in media error messages ("Not Support" → "Not Supported")
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/integration/example.test.js | Added integration test verifying full-line fragment exclusion behavior |
| src/core/render/embed.js | Modified extractFragmentContent to accept and handle fullLine parameter with updated regex logic |
| src/core/render/compiler.js | Added fragmentFullLine property assignment to embed configuration |
| src/core/render/compiler/media.js | Fixed grammar in video and audio error messages |
| docs/embed-files.md | Documented the new :fragmentFullLine option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New option
:fragmentFullLinethat when used will enable full-line ignore of file embed fragment lines.Related issue, if any:
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
Tested in the following browsers: