update tests

Author: maxdml

dbos/client_test.go

@@ -372,8 +372,8 @@ func TestCancelResume(t *testing.T) {
 		result, err := resumeHandle.GetResult()
 		require.NoError(t, err, "failed to get result from resumed workflow")
 
-		// Verify the result
-		assert.Equal(t, input, result, "expected result to match input")
+		// Verify the result. Need to recast to int because JSON serialized it
+		assert.Equal(t, input, int(result.(float64)), "expected result to match input")
 
 		// Verify both steps completed
 		assert.Equal(t, 2, stepsCompleted, "expected steps completed to be 2")
@@ -394,7 +394,8 @@ func TestCancelResume(t *testing.T) {
 		resultAgain, err := resumeAgainHandle.GetResult()
 		require.NoError(t, err, "failed to get result from second resume")
 
-		assert.Equal(t, input, resultAgain, "expected second resume result to match input")
+		// Need to recast to int because JSON serialized it to float64
+		assert.Equal(t, input, int(resultAgain.(float64)), "expected second resume result to match input")
 
 		// Verify steps didn't run again
 		assert.Equal(t, 2, stepsCompleted, "expected steps completed to remain 2 after second resume")

dbos/queues_test.go

@@ -540,8 +540,9 @@ func TestQueueRecovery(t *testing.T) {
 			// Root workflow case
 			result, err := h.GetResult()
 			require.NoError(t, err, "failed to get result from recovered root workflow handle")
-			castedResult, ok := result.([]int)
-			require.True(t, ok, "expected result to be of type []int for root workflow, got %T", result)
+			// Need to re-marshal to []int because JSON serialized it to []interface{}
+			castedResult, err := convertJSONToType[[]int](result)
+			require.NoError(t, err, "failed to convert result to []int")
 			expectedResult := []int{0, 1, 2, 3, 4}
 			assert.Equal(t, expectedResult, castedResult, "expected result %v, got %v", expectedResult, castedResult)
 		}

dbos/workflow.go

@@ -976,9 +976,8 @@ func (c *dbosContext) RunWorkflow(_ DBOSContext, fn WorkflowFunc, input any, opt
 		result, err = fn(workflowCtx, input)
 
 		// Handle DBOS ID conflict errors by waiting workflow result
-		needsConversion := false
+		needsConversion := false // Notify the handle.GetResult() that we need to decode the result.
 		if errors.Is(err, &DBOSError{Code: ConflictingIDError}) {
-			fmt.Println("Detected workflow ID conflict error, awaiting existing workflow result")
 			c.logger.Warn("Workflow ID conflict detected. Waiting for existing workflow to complete", "workflow_id", workflowID)
 			result, err = retryWithResult(c, func() (any, error) {
 				return c.systemDB.awaitWorkflowResult(uncancellableCtx, workflowID)

dbos/workflows_test.go

@@ -827,7 +827,6 @@ func TestSteps(t *testing.T) {
 	})
 
 	t.Run("stepsOutputEncoding", func(t *testing.T) {
-
 		// Execute the workflow
 		handle, err := RunWorkflow(dbosCtx, userObjectWorkflow, "TestObject")
 		require.NoError(t, err, "failed to run workflow with user-defined objects")
@@ -846,17 +845,20 @@ func TestSteps(t *testing.T) {
 		require.NotNil(t, step.Output, "step output should not be nil")
 		assert.Nil(t, step.Error)
 
+		fmt.Println("step.Output", step.Output)
+
 		// Deserialize the output from the database to verify proper encoding
-		storedOutput, ok := step.Output.(StepOutput)
-		require.True(t, ok, "failed to cast step output to StepOutput")
+		// Need to recast to JSON because step.Output is an any type
+		storedOutput, err := convertJSONToType[StepOutput](step.Output)
+		require.NoError(t, err)
 
 		// Verify all fields were correctly serialized and deserialized
-		assert.Equal(t, "Processed_TestObject", storedOutput.ProcessedName, "ProcessedName not correctly serialized")
-		assert.Equal(t, 84, storedOutput.TotalCount, "TotalCount not correctly serialized")
-		assert.True(t, storedOutput.Success, "Success flag not correctly serialized")
-		assert.Len(t, storedOutput.Details, 3, "Details array length incorrect")
-		assert.Equal(t, []string{"step1", "step2", "step3"}, storedOutput.Details, "Details array not correctly serialized")
-		assert.False(t, storedOutput.ProcessedAt.IsZero(), "ProcessedAt timestamp should not be zero")
+		assert.Equal(t, "Processed_TestObject", storedOutput.ProcessedName)
+		assert.Equal(t, 84, storedOutput.TotalCount)
+		assert.True(t, storedOutput.Success)
+		assert.Len(t, storedOutput.Details, 3)
+		assert.Equal(t, []string{"step1", "step2", "step3"}, storedOutput.Details)
+		assert.False(t, storedOutput.ProcessedAt.IsZero())
 	})
 }
 
@@ -1412,8 +1414,8 @@ func TestWorkflowRecovery(t *testing.T) {
 			result, err := recoveredHandle.GetResult()
 			require.NoError(t, err, "failed to get result from recovered workflow %d", i)
 
-			// Result should be the counter value (1)
-			require.Equal(t, int64(1), result, "workflow %d result should be 1", i)
+			// Result should be the counter value (1). Will be float64 because JSON serialized it into an any type.
+			require.Equal(t, float64(1), result, "workflow %d result should be 1", i)
 		}
 
 		// Final verification of step states
@@ -1578,7 +1580,8 @@ func TestWorkflowDeadLetterQueue(t *testing.T) {
 		for i, h := range handles {
 			result, err := h.GetResult()
 			require.NoError(t, err, "failed to get result from handle %d", i)
-			require.Equal(t, 0, result)
+			// Will be float64 because JSON serialized it into an any type.
+			require.Equal(t, float64(0), result)
 		}
 	})
 }