Handling of the true expression is inconsistent

[stof]

👓 What did you see?

The shared test data has a parsing test for the empty expression, which is formatted as true.

As the formatted expression is meant to parsed as itself, it implies that true as expression should also be parsed into such true expression and not as a literal expression for the variable true, so that they are the same.

the shared test data does not cover the evaluation of those expressions.

✅ What did you expect to see?

true should probably become a special token producing the true expression. And tests should cover it.

📦 Which tool/library version are you using?

No response

🔬 How could we reproduce it?

No response

📚 Any additional context?

No response

[mpkorstanje]

As the formatted expression is meant to parsed as itself, it implies that true as expression should also be parsed into such true expression and not as a literal expression for the variable true, so that they are the same.

Alternatively, the True expression should be expressed as the empty string.

[mpkorstanje]

We can update this to the empty string and then fix the implementations.

tag-expressions/testdata/parsing.yml

Line 2 in b009d4f

formatted: 'true'

[stof]

this is another option indeed. In any case, its evaluation should be tested as well.

[mpkorstanje]

In any case, its evaluation should be tested as well.

Agreed.