Roll bindgen to pick up a compatibility fix with Clang 22

This picks up rust-lang/rust-bindgen#3278
and also adds the tests to the build process to catch such problems
earlier.

Bug: 440975178
Change-Id: Id919ff4d6191ab04267d961eef3e993665788052
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6890874
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1507661}

Author: zmodem

DEPS

@@ -1019,31 +1019,31 @@ deps = {
     'condition': 'not rust_force_head_revision',
     'objects': [
       {
-        'object_name': 'Linux_x64/rust-toolchain-22be76b7e259f27bf3e55eb931f354cd8b69d55f-3-llvmorg-21-init-16348-gbd809ffb.tar.xz',
-        'sha256sum': '5f8e9ad847e5bf586e0de1bb563c9a49e05ad36edfad5037900d7510004fc577',
-        'size_bytes': 138573136,
-        'generation': 1750840933611077,
+        'object_name': 'Linux_x64/rust-toolchain-22be76b7e259f27bf3e55eb931f354cd8b69d55f-4-llvmorg-21-init-16348-gbd809ffb.tar.xz',
+        'sha256sum': '3e5cf980edb893cbdc915d62bce1b29b896eda6df6455e145200bf25a52576b1',
+        'size_bytes': 159517088,
+        'generation': 1756377175296503,
         'condition': 'host_os == "linux" and non_git_source',
       },
       {
-        'object_name': 'Mac/rust-toolchain-22be76b7e259f27bf3e55eb931f354cd8b69d55f-3-llvmorg-21-init-16348-gbd809ffb.tar.xz',
-        'sha256sum': '357db812ca0a518ef0fc4394ddc859d68f23384931294412b7424bb3aabb3c09',
-        'size_bytes': 132392604,
-        'generation': 1750840935469331,
+        'object_name': 'Mac/rust-toolchain-22be76b7e259f27bf3e55eb931f354cd8b69d55f-4-llvmorg-21-init-16348-gbd809ffb.tar.xz',
+        'sha256sum': '8f0d15259a48df6c284ebcfb9dfb0ecba77d8267620aae1ff42d23a2f595ad77',
+        'size_bytes': 132425148,
+        'generation': 1756377177172203,
         'condition': 'host_os == "mac" and host_cpu == "x64"',
       },
       {
-        'object_name': 'Mac_arm64/rust-toolchain-22be76b7e259f27bf3e55eb931f354cd8b69d55f-3-llvmorg-21-init-16348-gbd809ffb.tar.xz',
-        'sha256sum': 'd3cb60c6388e86d3d1a0c46c539f1ea0ed1ff48cf907dc21b2cb5ff441b23c03',
-        'size_bytes': 120354192,
-        'generation': 1750840937280735,
+        'object_name': 'Mac_arm64/rust-toolchain-22be76b7e259f27bf3e55eb931f354cd8b69d55f-4-llvmorg-21-init-16348-gbd809ffb.tar.xz',
+        'sha256sum': 'ef0f5795e28fde6b0708647500fc94138e9518f173c3e99321cd8918006f606c',
+        'size_bytes': 120345408,
+        'generation': 1756377179094363,
         'condition': 'host_os == "mac" and host_cpu == "arm64"',
       },
       {
-        'object_name': 'Win/rust-toolchain-22be76b7e259f27bf3e55eb931f354cd8b69d55f-3-llvmorg-21-init-16348-gbd809ffb.tar.xz',
-        'sha256sum': '7e804f3a8bef4c8ca32d3368ca7564e5c12b684899453d9a522bdd05b1f1df7b',
-        'size_bytes': 195000356,
-        'generation': 1750840939064273,
+        'object_name': 'Win/rust-toolchain-22be76b7e259f27bf3e55eb931f354cd8b69d55f-4-llvmorg-21-init-16348-gbd809ffb.tar.xz',
+        'sha256sum': '056cfdae49dd3d73b38ca7ef8245dec2105c7a77b47efba99995552ea1d89f6e',
+        'size_bytes': 194943632,
+        'generation': 1756377180954050,
         'condition': 'host_os == "win"',
       },
     ],

tools/rust/build_bindgen.py

@@ -27,8 +27,8 @@
 from update import (RmTree)
 
 # The git hash to use.  See https://github.com/rust-lang/rust-bindgen/tags.
-# The current hash below corresponds to version 0.72.0
-BINDGEN_GIT_VERSION = 'd0e7d6b5b763e93dd38f9ece05230979ede95a0a'
+# The current hash below corresponds to something between 0.72.0 and 0.73.0.
+BINDGEN_GIT_VERSION = '2426dd68cd12e0ac022bca18efb9c7d0acd27e12'
 BINDGEN_GIT_REPO = ('https://chromium.googlesource.com/external/' +
                     'github.com/rust-lang/rust-bindgen')
 
@@ -46,6 +46,16 @@
 
 EXE = '.exe' if sys.platform == 'win32' else ''
 
+# TODO(crbug.com/440975178) Not all tests pass.
+EXCLUDED_TESTS = [
+    'emit_depfile',
+    'header_allowlist_file_hpp',
+    'header_blocklist_file_hpp',
+    'header_constified_enum_module_overflow_hpp',
+    'header_issue_544_stylo_creduce_2_hpp',
+    'header_nsbasehashtable_hpp',
+    'header_typedef_pointer_overlap_h'
+]
 
 def FetchNcurseswLibrary():
     assert sys.platform.startswith('linux')
@@ -164,6 +174,9 @@ def main():
         '--skip-checkout',
         action='store_true',
         help='skip downloading the git repo. Useful for trying local changes')
+    parser.add_argument('--skip-test',
+                        action='store_true',
+                        help='skip running tests')
     args, rest = parser.parse_known_args()
 
     if not args.skip_checkout:
@@ -212,6 +225,14 @@ def main():
                 shutil.copy(os.path.join(llvm_dir, 'lib', filename),
                             os.path.join(install_dir, 'lib'),
                             follow_symlinks=False)
+
+    if not args.skip_test:
+        test_args = ['test', '--lib', '--bins', '--tests', '--']
+        for excluded in EXCLUDED_TESTS:
+            test_args.append('--skip')
+            test_args.append(excluded)
+        RunCargo(test_args)
+
     return 0
 
 

tools/rust/update_rust.py

@@ -37,7 +37,7 @@
 # should not be changed manually.
 # They are also read by build/config/compiler/BUILD.gn.
 RUST_REVISION = '22be76b7e259f27bf3e55eb931f354cd8b69d55f'
-RUST_SUB_REVISION = 3
+RUST_SUB_REVISION = 4
 
 # The revision of Crubit to use from https://github.com/google/crubit
 #