Merge PR for 4101-4104 (already reviewed) #4121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry string parameters (#4101) * Generate PutBucketMetricsConfiguration and generate check to see if required query string params are set. Remove visitor pattern and move custom logic for putlifecycleconfiguration marshaller to custom partial method * fix failing unit test for abortmultipartupload * update expectedbucketowner for pbmcrequest
* Generate PutBucketMetricsConfiguration and generate check to see if required query string params are set. Remove visitor pattern and move custom logic for putlifecycleconfiguration marshaller to custom partial method * generate getbucketmetricsconfiguration * fix failing unit test for abortmultipartupload * fix failing unit test for abortmultipartupload * update IsSetExpectedBucketOwner
* Generate PutBucketMetricsConfiguration and generate check to see if required query string params are set. Remove visitor pattern and move custom logic for putlifecycleconfiguration marshaller to custom partial method * Generate ListBucketMetricsConfiguration * generate getbucketmetricsconfiguration * fix failing unit test for abortmultipartupload * fix failing unit test for abortmultipartupload * update stringIsNullEmpty for string isSet methods
* Generate PutBucketMetricsConfiguration and generate check to see if required query string params are set. Remove visitor pattern and move custom logic for putlifecycleconfiguration marshaller to custom partial method * Generate ListBucketMetricsConfiguration * generate getbucketmetricsconfiguration * fix failing unit test for abortmultipartupload * fix failing unit test for abortmultipartupload * generate deletebucketmetricsconfiguration * update stringIsNullEmpty for string isSet methods * fix IsSet for string properties
GarrettBeatty
approved these changes
Nov 11, 2025
boblodgett
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ONLY REVIEW THIS COMMIT (to consolidate devconfigs) : 31719e3
Generates 4 S3 operations. Put, Get, List, Delete BucketMetricsConfiguration
All commits in this PR have already been reviewed in these PR's except the commit to consolidate devconfigs
#4101
#4102
#4103
#4104
Motivation and Context
Road to S3 model generation.
Testing
Dry run 6bfdd47c-60ae-4a6d-a509-a943437794d1 (just to be safe im dry running again) PASSED
Screenshots (if appropriate)
Types of changes
Checklist
License