generate deletebucketmetricsconfiguration (#4104)

* Generate PutBucketMetricsConfiguration and generate check to see if required query string params are set. Remove visitor pattern and move custom logic for putlifecycleconfiguration marshaller to custom partial method

* Generate ListBucketMetricsConfiguration

* generate getbucketmetricsconfiguration

* fix failing unit test for abortmultipartupload

* fix failing unit test for abortmultipartupload

* generate deletebucketmetricsconfiguration

* update stringIsNullEmpty for string isSet methods

* fix IsSet for string properties

Author: peterrsongg

generator/.DevConfigs/b75d0287-d293-4a03-ad2f-1aa096a32665.json

@@ -0,0 +1,11 @@
+{
+  "services": [
+    {
+      "serviceName": "S3",
+      "type": "patch",
+      "changeLogMessages": [
+        "generate DeleteBucketMetricsConfiguration"
+      ]
+    }
+  ]
+}

generator/ServiceClientGeneratorLib/ServiceModel.cs

@@ -566,7 +566,7 @@ public List<Operation> S3AllowListOperations
                         //new Operation(this, "PutBucketIntelligentTieringConfiguration", DocumentRoot[OperationsKey]["PutBucketIntelligentTieringConfiguration"]),
                         //new Operation(this, "PutBucketInventoryConfiguration", DocumentRoot[OperationsKey]["PutBucketInventoryConfiguration"]),
                         new Operation(this, "PutBucketMetricsConfiguration", DocumentRoot[OperationsKey]["PutBucketMetricsConfiguration"]),
-                        // new Operation(this, "DeleteBucketMetricsConfiguration", DocumentRoot[OperationsKey]["DeleteBucketMetricsConfiguration"]),
+                        new Operation(this, "DeleteBucketMetricsConfiguration", DocumentRoot[OperationsKey]["DeleteBucketMetricsConfiguration"]),
                         //new Operation(this, "DeleteBucketAnalyticsConfiguration", DocumentRoot[OperationsKey]["DeleteBucketAnalyticsConfiguration"]),
                         //new Operation(this, "DeleteBucketIntelligentTieringConfiguration", DocumentRoot[OperationsKey]["DeleteBucketIntelligentTieringConfiguration"]),
                         //new Operation(this, "DeleteBucketInventoryConfiguration", DocumentRoot[OperationsKey]["DeleteBucketInventoryConfiguration"]),

generator/ServiceModels/s3/s3.customizations.json

@@ -858,6 +858,19 @@
                     "ExpectedBucketOwner" :{"injectXmlIsSet" :["return !string.IsNullOrEmpty(this._expectedBucketOwner);"]}
                 }
             ]
+        },
+        "DeleteBucketMetricsConfigurationRequest":{
+            "modify":[
+                {
+                    "Id":{"emitPropertyName": "MetricsId"}
+                },
+                {
+                    "ExpectedBucketOwner" :{"injectXmlIsSet":["return !string.IsNullOrEmpty(this._expectedBucketOwner);"]}
+                },
+                {
+                    "MetricsId":{"injectXmlIsSet":["return !string.IsNullOrEmpty(this._metricsId);"]}
+                }
+            ]
         }
     },
     "operationModifiers": {