Skip to content

Commit 1883db9

Browse files
fix silently failing test (#4073)
1 parent 923d833 commit 1883db9

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

sdk/test/Services/S3/IntegrationTests/TransferUtilityTests.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -909,7 +909,7 @@ public void MultipartUploadUnseekableStreamCompletedEventTest()
909909
Assert.IsNotNull(args.Request);
910910
Assert.IsNotNull(args.Response);
911911
Assert.AreEqual(-1, args.TotalBytes); // Unseekable streams have unknown length
912-
Assert.AreEqual(20 * MEG_SIZE, args.TransferredBytes); // since we know the actual length via testing it, we can check the transferredbytes size
912+
Assert.AreEqual(0, args.TransferredBytes); // unseekable streams we dont attach and progress listeners so we wont have transferredbytes.
913913
}
914914
};
915915
UploadUnseekableStreamWithLifecycleEvents(20 * MEG_SIZE, null, eventValidator, null);
@@ -964,7 +964,7 @@ public void MultipartUploadUnseekableStreamCompleteLifecycleTest()
964964
Assert.IsNotNull(args.Request);
965965
Assert.IsNotNull(args.Response);
966966
Assert.AreEqual(-1, args.TotalBytes); // Unseekable streams have unknown length
967-
Assert.AreEqual(18 * MEG_SIZE, args.TransferredBytes); // Should have transferred all bytes
967+
Assert.AreEqual(0, args.TransferredBytes); // unseekable streams we dont attach and progress listeners so we wont have transferredbytes.
968968
}
969969
};
970970

@@ -1758,15 +1758,16 @@ public void OnEventFired(object sender, T eventArgs)
17581758
{
17591759
try
17601760
{
1761-
EventFired = true;
17621761
Console.WriteLine("Lifecycle Event Fired: {0}", typeof(T).Name);
17631762
Validate?.Invoke(eventArgs);
1763+
EventFired = true; // Only set if validation passes
17641764
}
17651765
catch (Exception ex)
17661766
{
17671767
EventException = ex;
1768+
EventFired = false; // Ensure we don't mark as fired on failure
17681769
Console.WriteLine("Exception caught in lifecycle event: {0}", ex.Message);
1769-
throw;
1770+
// Don't re-throw, let AssertEventFired() handle it
17701771
}
17711772
}
17721773

0 commit comments

Comments
 (0)