Merge pull request #1 from StreamUI/062624-video-quality

Added more keyframes per fps as video was very low quality

Author: Jonovono

Examples/VideoViews/SceneKitTestView.swift

@@ -0,0 +1,8 @@
+//
+//  File.swift
+//  
+//
+//  Created by Jordan Howlett on 6/26/24.
+//
+
+import Foundation

Sources/StreamUI/Helpers/FrameTimer.swift

@@ -8,6 +8,7 @@
 import CoreMedia
 import Foundation
 
+@Observable
 public class FrameTimer {
     private var startTime: CMTime?
     public var frameCount: Int = 0

Sources/StreamUI/Helpers/RenderSettings.swift

@@ -81,4 +81,9 @@ public struct RenderSettings {
         default: return 3_000_000 // for 16/9 1080p
         }
     }
+
+    func getDefaultKeyframeInterval() -> Int32 {
+        // Default to a keyframe every 2 seconds, but cap at 60 frames
+        return min(fps * 2, 60)
+    }
 }

Sources/StreamUI/Recorders/VideoRecorder/VideoRecorder.swift

@@ -30,12 +30,12 @@ class VideoRecorder {
     func setupVideoInput() {
         guard let assetWriter = parentRecorder?.assetWriter else { return }
 
-        // Define compression properties
         let compressionProperties: [String: Any] = [
             AVVideoAverageBitRateKey: renderSettings.getDefaultBitrate(),
-            AVVideoMaxKeyFrameIntervalKey: 1, // Force keyframe at start
+            AVVideoMaxKeyFrameIntervalKey: renderSettings.getDefaultKeyframeInterval(), // Keyframe every 1 second at 30 fps
             AVVideoProfileLevelKey: AVVideoProfileLevelH264High41,
-            AVVideoH264EntropyModeKey: AVVideoH264EntropyModeCABAC
+            AVVideoH264EntropyModeKey: AVVideoH264EntropyModeCABAC,
+            AVVideoQualityKey: 0.1 // High quality (0.0 - 1.0)
         ]
 
         let videoSettings: [String: Any] = [