Skip to content

Commit cb867db

Browse files
committed
Revert changes to telemetry SSL requirements
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
1 parent 62207b6 commit cb867db

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

server/src/com/mirth/connect/client/core/ConnectServiceUtil.java

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,11 @@
3636
import org.apache.http.client.methods.HttpPost;
3737
import org.apache.http.client.protocol.HttpClientContext;
3838
import org.apache.http.client.utils.HttpClientUtils;
39+
import org.apache.http.config.RegistryBuilder;
3940
import org.apache.http.config.SocketConfig;
4041
import org.apache.http.conn.socket.ConnectionSocketFactory;
42+
import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
43+
import org.apache.http.conn.ssl.SSLContexts;
4144
import org.apache.http.entity.ContentType;
4245
import org.apache.http.impl.client.CloseableHttpClient;
4346
import org.apache.http.impl.client.HttpClients;
@@ -55,6 +58,7 @@
5558
import com.mirth.connect.model.User;
5659
import com.mirth.connect.model.converters.ObjectXMLSerializer;
5760
import com.mirth.connect.model.notification.Notification;
61+
import com.mirth.connect.util.MirthSSLUtil;
5862

5963
public class ConnectServiceUtil {
6064
private final static String URL_CONNECT_SERVER = BrandingConstants.CONNECT_SERVER_URL;
@@ -258,11 +262,14 @@ public static boolean sendStatistics(String serverId, String mirthVersion, boole
258262
}
259263

260264
private static CloseableHttpClient getClient(String[] protocols, String[] cipherSuites) {
261-
BasicHttpClientConnectionManager httpClientConnectionManager = new BasicHttpClientConnectionManager();
265+
RegistryBuilder<ConnectionSocketFactory> socketFactoryRegistry = RegistryBuilder.<ConnectionSocketFactory> create();
266+
String[] enabledProtocols = MirthSSLUtil.getEnabledHttpsProtocols(protocols);
267+
String[] enabledCipherSuites = MirthSSLUtil.getEnabledHttpsCipherSuites(cipherSuites);
268+
SSLConnectionSocketFactory sslConnectionSocketFactory = new SSLConnectionSocketFactory(SSLContexts.createSystemDefault(), enabledProtocols, enabledCipherSuites, SSLConnectionSocketFactory.STRICT_HOSTNAME_VERIFIER);
269+
socketFactoryRegistry.register("https", sslConnectionSocketFactory);
270+
271+
BasicHttpClientConnectionManager httpClientConnectionManager = new BasicHttpClientConnectionManager(socketFactoryRegistry.build());
262272
httpClientConnectionManager.setSocketConfig(SocketConfig.custom().setSoTimeout(TIMEOUT).build());
263-
return HttpClients.custom()
264-
.useSystemProperties()
265-
.setConnectionManager(httpClientConnectionManager)
266-
.build();
273+
return HttpClients.custom().setConnectionManager(httpClientConnectionManager).build();
267274
}
268275
}

0 commit comments

Comments
 (0)